include/sfx2/thumbnailview.hxx   |    2 +-
 sfx2/inc/recentdocsview.hxx      |    2 +-
 sfx2/inc/templatedefaultview.hxx |    2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

New commits:
commit 5140e19a2d709339a986fa9fa1cf16ec185f444d
Author:     Dan Williams <[email protected]>
AuthorDate: Fri Dec 19 10:03:21 2025 -0600
Commit:     Ilmari Lauhakangas <[email protected]>
CommitDate: Mon Dec 22 15:59:55 2025 +0100

    tdf#169971 fix call order of derived ThumbnailView UpdateColors() method
    
    Derived class' UpdateColors() methods should be called rather than the
    base class method, otherwise the derived classes can't set the colors
    they want. Fixes an error in the patch for tdf#169727.
    
    Change-Id: I2f5828a81f1e4732e171f43d7407244e3f6e25a2
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/195942
    Tested-by: Jenkins
    Reviewed-by: Ilmari Lauhakangas <[email protected]>

diff --git a/include/sfx2/thumbnailview.hxx b/include/sfx2/thumbnailview.hxx
index fcca2416359a..572c3d344ce8 100644
--- a/include/sfx2/thumbnailview.hxx
+++ b/include/sfx2/thumbnailview.hxx
@@ -262,7 +262,7 @@ protected:
     virtual void OnItemDblClicked (ThumbnailViewItem *pItem);
 
     // Update internal colors from system color scheme or other sources
-    SAL_DLLPRIVATE void UpdateColors(const StyleSettings& rSettings);
+    virtual void UpdateColors(const StyleSettings& rSettings);
 
 protected:
 
diff --git a/sfx2/inc/recentdocsview.hxx b/sfx2/inc/recentdocsview.hxx
index 5063f7c56502..42b57497ed9e 100644
--- a/sfx2/inc/recentdocsview.hxx
+++ b/sfx2/inc/recentdocsview.hxx
@@ -86,7 +86,7 @@ public:
     void setFilter(ApplicationType aFilter);
 
 protected:
-    void UpdateColors(const StyleSettings& rSettings);
+    void UpdateColors(const StyleSettings& rSettings) override;
 
 private:
     virtual bool MouseButtonDown( const MouseEvent& rMEvt ) override;
diff --git a/sfx2/inc/templatedefaultview.hxx b/sfx2/inc/templatedefaultview.hxx
index 0bfd88c2c07e..286d5355c30d 100644
--- a/sfx2/inc/templatedefaultview.hxx
+++ b/sfx2/inc/templatedefaultview.hxx
@@ -26,7 +26,7 @@ public:
     void createContextMenu();
 
 protected:
-    void UpdateColors(const StyleSettings& rSettings);
+    void UpdateColors(const StyleSettings& rSettings) override;
 };
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */

Reply via email to