Hi,
Please find the latest report on new defect(s) introduced to LibreOffice found
with Coverity Scan.
3 new defect(s) introduced to LibreOffice found with Coverity Scan.
10 defect(s), reported by Coverity Scan earlier, were marked fixed in the
recent build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 3 of 3 defect(s)
** CID 1677826: Error handling issues (NEGATIVE_RETURNS)
/fpicker/source/office/PlacesListBox.cxx: 154 in
PlacesListBox::updateView()()
_____________________________________________________________________________________________
*** CID 1677826: Error handling issues (NEGATIVE_RETURNS)
/fpicker/source/office/PlacesListBox.cxx: 154 in
PlacesListBox::updateView()()
148 return OUString();
149 }
150
151 void PlacesListBox::updateView( )
152 {
153 sal_uInt32 nSelected = mxImpl->get_cursor_index();
>>> CID 1677826: Error handling issues (NEGATIVE_RETURNS)
>>> "nSelected" is passed to a parameter that cannot be negative. [Note:
>>> The source code implementation of the function has been overridden by a
>>> builtin model.]
154 PlacePtr pPlace = maPlaces[nSelected];
155 mpDlg->OpenURL_Impl( pPlace->GetUrl( ) );
156 }
157
** CID 1677825: Error handling issues (NEGATIVE_RETURNS)
/fpicker/source/office/PlacesListBox.cxx: 102 in
PlacesListBox::Selection(weld::TreeView &)()
_____________________________________________________________________________________________
*** CID 1677825: Error handling issues (NEGATIVE_RETURNS)
/fpicker/source/office/PlacesListBox.cxx: 102 in
PlacesListBox::Selection(weld::TreeView &)()
96 return theImage;
97 }
98
99 IMPL_LINK_NOARG( PlacesListBox, Selection, weld::TreeView&, void )
100 {
101 sal_uInt32 nSelected = mxImpl->get_cursor_index();
>>> CID 1677825: Error handling issues (NEGATIVE_RETURNS)
>>> "nSelected" is passed to a parameter that cannot be negative. [Note:
>>> The source code implementation of the function has been overridden by a
>>> builtin model.]
102 PlacePtr pPlace = maPlaces[nSelected];
103
104 if (pPlace->IsEditable())
105 mpDlg->RemovablePlaceSelected();
106 else
107 mpDlg->RemovablePlaceSelected(false);
** CID 1677824: Error handling issues (NEGATIVE_RETURNS)
/fpicker/source/office/PlacesListBox.cxx: 115 in
PlacesListBox::DoubleClick(weld::TreeView &)()
_____________________________________________________________________________________________
*** CID 1677824: Error handling issues (NEGATIVE_RETURNS)
/fpicker/source/office/PlacesListBox.cxx: 115 in
PlacesListBox::DoubleClick(weld::TreeView &)()
109 updateView();
110 }
111
112 IMPL_LINK_NOARG( PlacesListBox, DoubleClick, weld::TreeView&, bool )
113 {
114 sal_uInt16 nSelected = mxImpl->get_cursor_index();
>>> CID 1677824: Error handling issues (NEGATIVE_RETURNS)
>>> "nSelected" is passed to a parameter that cannot be negative. [Note:
>>> The source code implementation of the function has been overridden by a
>>> builtin model.]
115 PlacePtr pPlace = maPlaces[nSelected];
116 if ( !pPlace->IsEditable() || pPlace->IsLocal( ) )
117 return true;
118 PlaceEditDialog aDlg(mpDlg->getDialog(), pPlace);
119 short aRetCode = aDlg.run();
120 switch (aRetCode)
________________________________________________________________________________________________________
To view the defects in Coverity Scan visit,
https://scan.coverity.com/projects/libreoffice?tab=overview
