sw/source/ui/frmdlg/frmpage.cxx | 2 +- sw/uiconfig/swriter/ui/frmaddpage.ui | 6 +++--- sw/uiconfig/swriter/ui/frmtypepage.ui | 4 ++++ 3 files changed, 8 insertions(+), 4 deletions(-)
New commits: commit 4b41a3a33aedf21b712edb7632a24d0954932c6f Author: Parth Raiyani <[email protected]> AuthorDate: Wed Jan 28 15:26:22 2026 +0530 Commit: Caolán McNamara <[email protected]> CommitDate: Thu Jan 29 12:06:49 2026 +0100 a11y: enhance accessibility in frmaddpage.ui and frmtypepage.ui - add mnemonic-widget in GtkLabel to correctly reference relevant object - rename conflicting label ids Change-Id: I36fe46335faa93b068ef1c59ea5743134b4e0a4b Signed-off-by: Parth Raiyani <[email protected]> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/198306 Tested-by: Jenkins CollaboraOffice <[email protected]> Reviewed-by: Caolán McNamara <[email protected]> diff --git a/sw/source/ui/frmdlg/frmpage.cxx b/sw/source/ui/frmdlg/frmpage.cxx index 5de4a804bbf0..025250de3f4b 100644 --- a/sw/source/ui/frmdlg/frmpage.cxx +++ b/sw/source/ui/frmdlg/frmpage.cxx @@ -2945,7 +2945,7 @@ SwFrameAddPage::SwFrameAddPage(weld::Container* pPage, weld::DialogController* p , m_bFormat(false) , m_bNew(false) , m_xNameFrame(m_xBuilder->weld_widget(u"nameframe"_ustr)) - , m_xNameFT(m_xBuilder->weld_label(u"name_label"_ustr)) + , m_xNameFT(m_xBuilder->weld_label(u"frm_add_name_label"_ustr)) , m_xNameED(m_xBuilder->weld_entry(u"name"_ustr)) , m_xAltNameFT(m_xBuilder->weld_label(u"altname_label"_ustr)) , m_xAltNameED(m_xBuilder->weld_entry(u"altname"_ustr)) diff --git a/sw/uiconfig/swriter/ui/frmaddpage.ui b/sw/uiconfig/swriter/ui/frmaddpage.ui index f3200ad1121f..354cf4da92ca 100644 --- a/sw/uiconfig/swriter/ui/frmaddpage.ui +++ b/sw/uiconfig/swriter/ui/frmaddpage.ui @@ -92,7 +92,7 @@ </packing> </child> <child> - <object class="GtkLabel" id="name_label"> + <object class="GtkLabel" id="frm_add_name_label"> <property name="visible">True</property> <property name="can-focus">False</property> <property name="label" translatable="yes" context="frmaddpage|name_label">_Name:</property> @@ -230,7 +230,7 @@ <property name="margin-top">6</property> <property name="column-spacing">12</property> <child> - <object class="GtkLabel" id="label2"> + <object class="GtkLabel" id="frm_add_label2"> <property name="visible">True</property> <property name="can-focus">False</property> <property name="label" translatable="yes" context="frmaddpage|label2">_Vertical alignment:</property> @@ -498,7 +498,7 @@ <object class="GtkSizeGroup" id="sizegroup1"> <property name="ignore-hidden">True</property> <widgets> - <widget name="name_label"/> + <widget name="frm_add_name_label"/> <widget name="altname_label"/> <widget name="description_label"/> <widget name="textflow_label"/> diff --git a/sw/uiconfig/swriter/ui/frmtypepage.ui b/sw/uiconfig/swriter/ui/frmtypepage.ui index e54ab9811c47..eb7d61670800 100644 --- a/sw/uiconfig/swriter/ui/frmtypepage.ui +++ b/sw/uiconfig/swriter/ui/frmtypepage.ui @@ -71,6 +71,7 @@ <property name="visible">True</property> <property name="can-focus">False</property> <property name="label" translatable="yes" context="frmtypepage|widthft">_Width</property> + <property name="mnemonic-widget">width</property> <property name="use-underline">True</property> <property name="xalign">0</property> </object> @@ -85,6 +86,7 @@ <property name="visible">True</property> <property name="can-focus">False</property> <property name="label" translatable="yes" context="frmtypepage|autowidthft">_Width (at least)</property> + <property name="mnemonic-widget">width</property> <property name="use-underline">True</property> <property name="xalign">0</property> </object> @@ -194,6 +196,7 @@ <property name="visible">True</property> <property name="can-focus">False</property> <property name="label" translatable="yes" context="frmtypepage|heightft">H_eight</property> + <property name="mnemonic-widget">height</property> <property name="use-underline">True</property> <property name="xalign">0</property> </object> @@ -208,6 +211,7 @@ <property name="visible">True</property> <property name="can-focus">False</property> <property name="label" translatable="yes" context="frmtypepage|autoheightft">H_eight (at least)</property> + <property name="mnemonic-widget">height</property> <property name="use-underline">True</property> <property name="xalign">0</property> </object>
