cui/source/tabpages/chardlg.cxx | 2 +- cui/uiconfig/ui/charnamepage.ui | 15 +++++++++++++++ cui/uiconfig/ui/effectspage.ui | 9 +++++++-- cui/uiconfig/ui/twolinespage.ui | 12 ++++++++++++ sw/uiconfig/swriter/ui/insertbookmark.ui | 5 +++++ sw/uiconfig/swriter/ui/insertcaption.ui | 2 +- sw/uiconfig/swriter/ui/wrappage.ui | 2 +- 7 files changed, 42 insertions(+), 5 deletions(-)
New commits: commit 0255db61f7068ee1c9a503e36b62b66a3ca010d0 Author: Parth Raiyani <[email protected]> AuthorDate: Wed Jan 28 15:33:56 2026 +0530 Commit: Caolán McNamara <[email protected]> CommitDate: Thu Jan 29 12:17:42 2026 +0100 a11y: enhance accessibility in frmaddpage.ui and frmtypepage.ui - add static role in GtkLabel for better accessibility - rename conflicting label ids - add mnemonic-widget in GtkLabel to correctly reference relevant object Signed-off-by: Parth Raiyani <[email protected]> Change-Id: If5a1f1cac6fe9698a5fd7e64f2759a169acc9bfe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/198307 Reviewed-by: Caolán McNamara <[email protected]> Tested-by: Jenkins CollaboraOffice <[email protected]> Tested-by: Caolán McNamara <[email protected]> diff --git a/cui/source/tabpages/chardlg.cxx b/cui/source/tabpages/chardlg.cxx index 0b7aa845bf53..9007cbb35500 100644 --- a/cui/source/tabpages/chardlg.cxx +++ b/cui/source/tabpages/chardlg.cxx @@ -1309,7 +1309,7 @@ SvxCharEffectsPage::SvxCharEffectsPage(weld::Container* pPage, weld::DialogContr , m_xFontTransparencyFT(m_xBuilder->weld_label(u"fonttransparencyft"_ustr)) , m_xFontTransparencyMtr( m_xBuilder->weld_metric_spin_button(u"fonttransparencymtr"_ustr, FieldUnit::PERCENT)) - , m_xEffectsFT(m_xBuilder->weld_label(u"effectsft"_ustr)) + , m_xEffectsFT(m_xBuilder->weld_label(u"caseft"_ustr)) , m_xEffectsLB(m_xBuilder->weld_combo_box(u"effectslb"_ustr)) , m_xReliefFT(m_xBuilder->weld_label(u"reliefft"_ustr)) , m_xReliefLB(m_xBuilder->weld_combo_box(u"relieflb"_ustr)) diff --git a/cui/uiconfig/ui/charnamepage.ui b/cui/uiconfig/ui/charnamepage.ui index 8961ee260f8f..d79cfa041c4d 100644 --- a/cui/uiconfig/ui/charnamepage.ui +++ b/cui/uiconfig/ui/charnamepage.ui @@ -315,6 +315,11 @@ <attributes> <attribute name="scale" value="0.9"/> </attributes> + <child internal-child="accessible"> + <object class="AtkObject" id="lbWestFontinfo-atkobject"> + <property name="AtkObject::accessible-role">static</property> + </object> + </child> </object> <packing> <property name="left-attach">1</property> @@ -594,6 +599,11 @@ <attributes> <attribute name="scale" value="0.9"/> </attributes> + <child internal-child="accessible"> + <object class="AtkObject" id="lbCJKFontinfo-atkobject"> + <property name="AtkObject::accessible-role">static</property> + </object> + </child> </object> <packing> <property name="left-attach">1</property> @@ -848,6 +858,11 @@ <attributes> <attribute name="scale" value="0.9"/> </attributes> + <child internal-child="accessible"> + <object class="AtkObject" id="lbCTLFontinfo-atkobject"> + <property name="AtkObject::accessible-role">static</property> + </object> + </child> </object> <packing> <property name="left-attach">1</property> diff --git a/cui/uiconfig/ui/effectspage.ui b/cui/uiconfig/ui/effectspage.ui index 527d8d8e5eeb..fcae7d4a3f32 100644 --- a/cui/uiconfig/ui/effectspage.ui +++ b/cui/uiconfig/ui/effectspage.ui @@ -69,7 +69,7 @@ <property name="row-spacing">6</property> <property name="column-spacing">12</property> <child> - <object class="GtkLabel" id="effectsft"> + <object class="GtkLabel" id="caseft"> <property name="visible">True</property> <property name="can-focus">False</property> <property name="label" translatable="yes" context="effectspage|effectsft">_Case:</property> @@ -621,6 +621,11 @@ <property name="wrap">True</property> <property name="max-width-chars">50</property> <property name="xalign">0</property> + <child internal-child="accessible"> + <object class="AtkObject" id="a11ywarning-atkobject"> + <property name="AtkObject::accessible-role">static</property> + </object> + </child> </object> <packing> <property name="left-attach">1</property> @@ -691,7 +696,7 @@ <object class="GtkSizeGroup" id="sizegroup1"> <property name="ignore-hidden">True</property> <widgets> - <widget name="effectsft"/> + <widget name="caseft"/> <widget name="reliefft"/> <widget name="positionft"/> <widget name="emphasisft"/> diff --git a/cui/uiconfig/ui/twolinespage.ui b/cui/uiconfig/ui/twolinespage.ui index 79602dc7101a..9a9516c2702f 100644 --- a/cui/uiconfig/ui/twolinespage.ui +++ b/cui/uiconfig/ui/twolinespage.ui @@ -85,6 +85,12 @@ <property name="visible">True</property> <property name="can_focus">False</property> <property name="label" translatable="yes" context="twolinespage|label29">Initial character</property> + <property name="mnemonic-widget">startbracket</property> + <child internal-child="accessible"> + <object class="AtkObject" id="label29-atkobject"> + <property name="AtkObject::accessible-role">static</property> + </object> + </child> </object> <packing> <property name="left_attach">0</property> @@ -96,6 +102,12 @@ <property name="visible">True</property> <property name="can_focus">False</property> <property name="label" translatable="yes" context="twolinespage|label30">Final character</property> + <property name="mnemonic-widget">endbracket</property> + <child internal-child="accessible"> + <object class="AtkObject" id="label30-atkobject"> + <property name="AtkObject::accessible-role">static</property> + </object> + </child> </object> <packing> <property name="left_attach">1</property> diff --git a/sw/uiconfig/swriter/ui/insertbookmark.ui b/sw/uiconfig/swriter/ui/insertbookmark.ui index 0a183c4e1f51..bb7ca052ccdd 100644 --- a/sw/uiconfig/swriter/ui/insertbookmark.ui +++ b/sw/uiconfig/swriter/ui/insertbookmark.ui @@ -88,6 +88,11 @@ <property name="hexpand">True</property> <property name="label" translatable="no" context="insertbookmark|lbForbiddenChars">Forbidden characters:</property> <property name="single-line-mode">True</property> + <child internal-child="accessible"> + <object class="AtkObject" id="lbForbiddenChars-atkobject"> + <property name="AtkObject::accessible-role">static</property> + </object> + </child> </object> <packing> <property name="left-attach">1</property> diff --git a/sw/uiconfig/swriter/ui/insertcaption.ui b/sw/uiconfig/swriter/ui/insertcaption.ui index 32e896373f9a..031e16e90eb3 100644 --- a/sw/uiconfig/swriter/ui/insertcaption.ui +++ b/sw/uiconfig/swriter/ui/insertcaption.ui @@ -297,7 +297,7 @@ </packing> </child> <child> - <object class="GtkLabel" id="label4"> + <object class="GtkLabel" id="iclabel4"> <property name="visible">True</property> <property name="can_focus">False</property> <property name="halign">start</property> diff --git a/sw/uiconfig/swriter/ui/wrappage.ui b/sw/uiconfig/swriter/ui/wrappage.ui index be7187393fa1..d5301af81655 100644 --- a/sw/uiconfig/swriter/ui/wrappage.ui +++ b/sw/uiconfig/swriter/ui/wrappage.ui @@ -497,7 +497,7 @@ </packing> </child> <child> - <object class="GtkLabel" id="label7"> + <object class="GtkLabel" id="wraplabel7"> <property name="visible">True</property> <property name="can-focus">False</property> <property name="label" translatable="yes" context="wrappage|label7">_Bottom:</property>
