cui/uiconfig/ui/colorpage.ui | 4 ++-- cui/uiconfig/ui/paragalignpage.ui | 4 ++-- sfx2/uiconfig/ui/password.ui | 10 ++++++++++ sw/uiconfig/swriter/ui/linenumbering.ui | 6 ++++-- sw/uiconfig/swriter/ui/tabletextflowpage.ui | 1 + sw/uiconfig/swriter/ui/textgridpage.ui | 2 ++ sw/uiconfig/swriter/ui/watermarkdialog.ui | 9 +++++++++ 7 files changed, 30 insertions(+), 6 deletions(-)
New commits: commit 69827c694f1b59bf704596b1de5fa0cb02495edd Author: Parth Raiyani <[email protected]> AuthorDate: Wed Jan 28 18:55:48 2026 +0530 Commit: Caolán McNamara <[email protected]> CommitDate: Thu Jan 29 13:34:54 2026 +0100 a11y: fix accessibility issue in various UI components - rename conflicting label ids - add mnemonic-widget in GtkLabel to correctly reference relevant object - add static role in GtkLabel for better accessibility Change-Id: I1c49ed96c7f354494168cec5ed57aac680894bf0 Signed-off-by: Parth Raiyani <[email protected]> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/198317 Tested-by: Jenkins CollaboraOffice <[email protected]> Tested-by: Caolán McNamara <[email protected]> Reviewed-by: Caolán McNamara <[email protected]> diff --git a/cui/uiconfig/ui/colorpage.ui b/cui/uiconfig/ui/colorpage.ui index 5e08447d8cd0..91307a503074 100644 --- a/cui/uiconfig/ui/colorpage.ui +++ b/cui/uiconfig/ui/colorpage.ui @@ -150,7 +150,7 @@ <property name="orientation">vertical</property> <property name="spacing">3</property> <child> - <object class="GtkLabel" id="colorlabel20"> + <object class="GtkLabel" id="recentcolorlb"> <property name="visible">True</property> <property name="can-focus">False</property> <property name="label" translatable="yes" context="colorpage|label20">Recent Colors</property> @@ -158,7 +158,7 @@ <property name="mnemonic-widget">iconview_recent_colors</property> <property name="xalign">0</property> <child internal-child="accessible"> - <object class="AtkObject" id="colorlabel20-atkobject"> + <object class="AtkObject" id="recentcolorlb-atkobject"> <property name="AtkObject::accessible-role">static</property> </object> </child> diff --git a/cui/uiconfig/ui/paragalignpage.ui b/cui/uiconfig/ui/paragalignpage.ui index 40dc9acaecda..ba762901a825 100644 --- a/cui/uiconfig/ui/paragalignpage.ui +++ b/cui/uiconfig/ui/paragalignpage.ui @@ -364,7 +364,7 @@ <property name="margin-top">6</property> <property name="spacing">6</property> <child> - <object class="GtkLabel" id="label2"> + <object class="GtkLabel" id="paragalignlabel2"> <property name="visible">True</property> <property name="can-focus">False</property> <property name="label" translatable="yes" context="paragalignpage|label2">_Text direction:</property> @@ -417,7 +417,7 @@ <object class="GtkSizeGroup" id="sizegroup1"> <widgets> <widget name="labelFT_VERTALIGN"/> - <widget name="label2"/> + <widget name="paragalignlabel2"/> </widgets> </object> <object class="GtkSizeGroup" id="sizegroup2"> diff --git a/sfx2/uiconfig/ui/password.ui b/sfx2/uiconfig/ui/password.ui index f376fdcc7c0b..fc7f795024bb 100644 --- a/sfx2/uiconfig/ui/password.ui +++ b/sfx2/uiconfig/ui/password.ui @@ -208,6 +208,11 @@ <property name="halign">end</property> <property name="hexpand">False</property> <property name="wrap">True</property> + <child internal-child="accessible"> + <object class="AtkObject" id="pass1policylabel-atkobject"> + <property name="AtkObject::accessible-role">static</property> + </object> + </child> </object> <packing> <property name="left-attach">1</property> @@ -339,6 +344,11 @@ <property name="halign">end</property> <property name="hexpand">False</property> <property name="wrap">True</property> + <child internal-child="accessible"> + <object class="AtkObject" id="pass2policylabel-atkobject"> + <property name="AtkObject::accessible-role">static</property> + </object> + </child> </object> <packing> <property name="left-attach">1</property> diff --git a/sw/uiconfig/swriter/ui/linenumbering.ui b/sw/uiconfig/swriter/ui/linenumbering.ui index 8c48970a4720..195aa6d10632 100644 --- a/sw/uiconfig/swriter/ui/linenumbering.ui +++ b/sw/uiconfig/swriter/ui/linenumbering.ui @@ -168,7 +168,7 @@ </packing> </child> <child> - <object class="GtkLabel" id="position"> + <object class="GtkLabel" id="lmposition"> <property name="visible">True</property> <property name="can_focus">False</property> <property name="label" translatable="yes" context="linenumbering|position">Position:</property> @@ -311,6 +311,7 @@ <property name="visible">True</property> <property name="can_focus">False</property> <property name="label" translatable="yes" context="linenumbering|intervallines">lines</property> + <property name="mnemonic_widget">intervalspin</property> <property name="xalign">0</property> </object> <packing> @@ -435,6 +436,7 @@ <property name="visible">True</property> <property name="can_focus">False</property> <property name="label" translatable="yes" context="linenumbering|lines">lines</property> + <property name="mnemonic_widget">linesspin</property> <property name="xalign">0</property> </object> <packing> @@ -608,7 +610,7 @@ <widgets> <widget name="characterstyle"/> <widget name="format"/> - <widget name="position"/> + <widget name="lmposition"/> <widget name="spacing"/> <widget name="interval"/> <widget name="text"/> diff --git a/sw/uiconfig/swriter/ui/tabletextflowpage.ui b/sw/uiconfig/swriter/ui/tabletextflowpage.ui index 5b251afdcae7..f58e37a8bfda 100644 --- a/sw/uiconfig/swriter/ui/tabletextflowpage.ui +++ b/sw/uiconfig/swriter/ui/tabletextflowpage.ui @@ -415,6 +415,7 @@ <property name="visible">True</property> <property name="can-focus">False</property> <property name="label" translatable="yes" context="tabletextflowpage|label39">rows</property> + <property name="mnemonic-widget">repeatheadernf</property> </object> <packing> <property name="left-attach">2</property> diff --git a/sw/uiconfig/swriter/ui/textgridpage.ui b/sw/uiconfig/swriter/ui/textgridpage.ui index 9ec921675c66..eca5739173fa 100644 --- a/sw/uiconfig/swriter/ui/textgridpage.ui +++ b/sw/uiconfig/swriter/ui/textgridpage.ui @@ -248,6 +248,7 @@ <property name="can-focus">False</property> <property name="halign">start</property> <property name="label" context="textgridpage|labelFT_CHARRANGE">(1-45)</property> + <property name="mnemonic-widget">spinNF_CHARSPERLINE</property> <property name="use-underline">True</property> </object> <packing> @@ -293,6 +294,7 @@ <property name="can-focus">False</property> <property name="halign">start</property> <property name="label" context="textgridpage|labelFT_LINERANGE">(1-48)</property> + <property name="mnemonic-widget">spinNF_LINESPERPAGE</property> </object> <packing> <property name="left-attach">2</property> diff --git a/sw/uiconfig/swriter/ui/watermarkdialog.ui b/sw/uiconfig/swriter/ui/watermarkdialog.ui index 1a31bdbb5235..e95f219948b8 100644 --- a/sw/uiconfig/swriter/ui/watermarkdialog.ui +++ b/sw/uiconfig/swriter/ui/watermarkdialog.ui @@ -100,6 +100,7 @@ <property name="can_focus">False</property> <property name="halign">end</property> <property name="label" translatable="yes" context="watermarkdialog|TextLabel">Text</property> + <property name="mnemonic_widget">TextInput</property> </object> <packing> <property name="left_attach">0</property> @@ -130,6 +131,7 @@ <property name="can_focus">False</property> <property name="halign">end</property> <property name="label" translatable="yes" context="watermarkdialog|FontLabel">Font</property> + <property name="mnemonic_widget">FontBox</property> </object> <packing> <property name="left_attach">0</property> @@ -142,6 +144,7 @@ <property name="can_focus">False</property> <property name="halign">end</property> <property name="label" translatable="yes" context="watermarkdialog|AngleLabel">Angle</property> + <property name="mnemonic_widget">Angle</property> </object> <packing> <property name="left_attach">0</property> @@ -154,6 +157,7 @@ <property name="can_focus">False</property> <property name="halign">end</property> <property name="label" translatable="yes" context="watermarkdialog|TransparencyLabel">Transparency</property> + <property name="mnemonic_widget">Transparency</property> </object> <packing> <property name="left_attach">0</property> @@ -168,6 +172,11 @@ <property name="label" translatable="yes" context="watermarkdialog|ColorLabel">Color</property> <property name="use_underline">True</property> <property name="mnemonic_widget">Color</property> + <child internal-child="accessible"> + <object class="AtkObject" id="ColorLabel-atkobject"> + <property name="AtkObject::accessible-role">static</property> + </object> + </child> </object> <packing> <property name="left_attach">0</property>
