sc/qa/uitest/conditional_format/colorScale.py | 14 +++++++------- sc/qa/uitest/conditional_format/iconSet.py | 4 ++-- 2 files changed, 9 insertions(+), 9 deletions(-)
New commits: commit 46af67b2ace6d839fdcf345a41198b6554e5be2b Author: ashtroll <[email protected]> AuthorDate: Thu Jan 1 12:27:00 2026 +0530 Commit: Ilmari Lauhakangas <[email protected]> CommitDate: Sat Jan 31 09:11:07 2026 +0100 tdf#97361 Make calc conditional format UI tests more pythonic Replace getByIndex() calls with direct Python-style indexing [0] in colorScale and iconSet UI tests for cleaner, more readable code. Change-Id: Ib365ab9ee41259ed3ab6eb51907700e548b09440 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/196386 Tested-by: Jenkins Reviewed-by: Ilmari Lauhakangas <[email protected]> diff --git a/sc/qa/uitest/conditional_format/colorScale.py b/sc/qa/uitest/conditional_format/colorScale.py index ee52f76abc2e..a9ac351be186 100644 --- a/sc/qa/uitest/conditional_format/colorScale.py +++ b/sc/qa/uitest/conditional_format/colorScale.py @@ -44,10 +44,10 @@ class colorScale(UITestCase): self.assertEqual("", get_state_as_dict(xCondFormat.getChild("edcolscalemax"))["Text"]) self.assertEqual(1, cond_formats.Length) - self.assertEqual(3, len(cond_formats.ConditionalFormats[0].getByIndex(0).ColorScaleEntries)) - self.assertEqual(16711680, cond_formats.ConditionalFormats[0].getByIndex(0).ColorScaleEntries[0].Color) - self.assertEqual(16776960, cond_formats.ConditionalFormats[0].getByIndex(0).ColorScaleEntries[1].Color) - self.assertEqual(43315, cond_formats.ConditionalFormats[0].getByIndex(0).ColorScaleEntries[2].Color) + self.assertEqual(3, len(cond_formats.ConditionalFormats[0][0].ColorScaleEntries)) + self.assertEqual(16711680, cond_formats.ConditionalFormats[0][0].ColorScaleEntries[0].Color) + self.assertEqual(16776960, cond_formats.ConditionalFormats[0][0].ColorScaleEntries[1].Color) + self.assertEqual(43315, cond_formats.ConditionalFormats[0][0].ColorScaleEntries[2].Color) def test_colorScale2Entries(self): @@ -86,8 +86,8 @@ class colorScale(UITestCase): self.ui_test.close_dialog_through_button(xOKBtn) self.assertEqual(1, cond_formats.Length) - self.assertEqual(2, len(cond_formats.ConditionalFormats[0].getByIndex(0).ColorScaleEntries)) - self.assertEqual(16777069, cond_formats.ConditionalFormats[0].getByIndex(0).ColorScaleEntries[0].Color) - self.assertEqual(7847013, cond_formats.ConditionalFormats[0].getByIndex(0).ColorScaleEntries[1].Color) + self.assertEqual(2, len(cond_formats.ConditionalFormats[0][0].ColorScaleEntries)) + self.assertEqual(16777069, cond_formats.ConditionalFormats[0][0].ColorScaleEntries[0].Color) + self.assertEqual(7847013, cond_formats.ConditionalFormats[0][0].ColorScaleEntries[1].Color) # vim: set shiftwidth=4 softtabstop=4 expandtab: diff --git a/sc/qa/uitest/conditional_format/iconSet.py b/sc/qa/uitest/conditional_format/iconSet.py index 9effeb646b21..da60835c495e 100644 --- a/sc/qa/uitest/conditional_format/iconSet.py +++ b/sc/qa/uitest/conditional_format/iconSet.py @@ -51,7 +51,7 @@ class IconSet(UITestCase): self.ui_test.close_dialog_through_button(xOKBtn) self.assertEqual(1, cond_formats.Length) - self.assertEqual(11, cond_formats.ConditionalFormats[0].getByIndex(0).Icons) # IconSet_4ArrowsGray - self.assertEqual(4, len(cond_formats.ConditionalFormats[0].getByIndex(0).IconSetEntries)) + self.assertEqual(11, cond_formats.ConditionalFormats[0][0].Icons) # IconSet_4ArrowsGray + self.assertEqual(4, len(cond_formats.ConditionalFormats[0][0].IconSetEntries)) # vim: set shiftwidth=4 softtabstop=4 expandtab:
