vcl/jsdialog/enabled.cxx | 33 +++++++++++++++++++++++++++++++-- 1 file changed, 31 insertions(+), 2 deletions(-)
New commits: commit 2643e5de0488e31e90a659c89a9ccaee2ae7fa6c Author: Caolán McNamara <[email protected]> AuthorDate: Mon Feb 9 15:25:20 2026 +0000 Commit: Miklos Vajna <[email protected]> CommitDate: Fri Feb 13 09:45:57 2026 +0100 exclude some unreachable dialogs Change-Id: Ic7e2d683c26c3e89fd7522d991d3a73929bad7f7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/199285 Reviewed-by: Miklos Vajna <[email protected]> Tested-by: Jenkins CollaboraOffice <[email protected]> diff --git a/vcl/jsdialog/enabled.cxx b/vcl/jsdialog/enabled.cxx index 9a3dcc8770d0..f3dd7bdb14c6 100644 --- a/vcl/jsdialog/enabled.cxx +++ b/vcl/jsdialog/enabled.cxx @@ -696,6 +696,14 @@ std::vector<OUString> completeCalcDialogList(const o3tl::sorted_vector<OUString> // for SID_OUTLINE_REMOVE if (entry == u"modules/scalc/ui/ungroupdialog.ui") continue; + // Skip this one for now, it can only be seen in certain xlsx documents + else if (entry == u"modules/scalc/ui/definetablerangedialog.ui") + continue; + // Skip this one, I think it can only happen on loading + // an archaic lotus 123 file + else if (entry == u"modules/scalc/ui/imoptdialog.ui") + continue; + OUString sEntry(entry); if (!entries.contains(sEntry)) missing.push_back(sEntry); @@ -789,15 +797,36 @@ std::vector<OUString> completeCommonDialogList(const o3tl::sorted_vector<OUStrin if (o3tl::starts_with(entry, u"writerperfect")) continue; // The manage changes dialog is only enabled in writer - else if (entry == u"svx/ui/acceptrejectchangesdialog.ui") + else if (entry == u"svx/ui/acceptrejectchangesdialog.ui" || + entry == u"svx/ui/redlinecontrol.ui" || + entry == u"svx/ui/redlinefilterpage.ui" || + entry == u"svx/ui/redlineviewpage.ui") + { continue; + } } if (docType == LOK_DOCTYPE_SPREADSHEET) { // Not supported in Calc if (entry == u"svx/ui/gotopagedialog.ui" || - entry == u"cui/ui/splitcellsdialog.ui") + entry == u"cui/ui/borderareatransparencydialog.ui" || + entry == u"cui/ui/splitcellsdialog.ui" || + entry == u"cui/ui/objectnamedialog.ui" || + entry == u"cui/ui/objecttitledescdialog.ui" || + entry == u"cui/ui/croppage.ui" || + entry == u"cui/ui/spinbox.ui" || + entry == u"cui/ui/formatnumberdialog.ui" || + entry == u"cui/ui/numberingoptionspage.ui" || + entry == u"cui/ui/numberingpositionpage.ui" || + entry == u"cui/ui/pastespecial.ui" || + entry == u"cui/ui/textflowpage.ui" || + entry == u"cui/ui/twolinespage.ui" || + entry == u"cui/ui/pickbulletpage.ui" || + entry == u"cui/ui/pickgraphicpage.ui" || + entry == u"cui/ui/picknumberingpage.ui" || + entry == u"cui/ui/pickoutlinepage.ui" || + entry == u"sfx/ui/password.ui") { continue; }
