filter/source/pdf/pdfinteract.cxx | 7 +++---- vcl/jsdialog/enabled.cxx | 29 +++++++++++++++++++++++++++++ 2 files changed, 32 insertions(+), 4 deletions(-)
New commits: commit 1c9a4072cac5e489d13eb34ae7fe491231e016dd Author: Caolán McNamara <[email protected]> AuthorDate: Mon Jan 26 16:40:32 2026 +0000 Commit: Caolán McNamara <[email protected]> CommitDate: Tue Feb 24 09:21:32 2026 +0100 add the 'Other' category into coverage report Change-Id: I509dc47fd66da92ac4a4a9d2f4e76f9080b2c85c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/198171 Reviewed-by: Miklos Vajna <[email protected]> Tested-by: Jenkins CollaboraOffice <[email protected]> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/200105 Reviewed-by: Caolán McNamara <[email protected]> diff --git a/vcl/jsdialog/enabled.cxx b/vcl/jsdialog/enabled.cxx index 0ec60a9dadec..9e5c649f4819 100644 --- a/vcl/jsdialog/enabled.cxx +++ b/vcl/jsdialog/enabled.cxx @@ -731,6 +731,10 @@ std::vector<OUString> completeCommonDialogList(const o3tl::sorted_vector<OUStrin // Skip this one, I don't think it can appear in practice if (entry == u"sfx/ui/cmisinfopage.ui") continue; + // Skip this one, I think it can only happen on loading + // an archaic wordperfect file + else if (entry == u"writerperfect/ui/wpftencodingdialog.ui") + continue; // Skip this one, I don't think it can appear in practice else if (entry == u"cui/ui/colorpickerdialog.ui") continue; @@ -760,6 +764,30 @@ std::vector<OUString> completeCommonDialogList(const o3tl::sorted_vector<OUStrin // from calc. else if (entry == u"cui/ui/eventassigndialog.ui") continue; + // Skip this one, it is disabled in filter/source/pdf/impdialog.cxx + // for kit mode + else if (entry == u"filter/ui/pdfsignpage.ui") + continue; + // This, for the chart wizard, it is really only available in calc + else if (entry == u"vcl/ui/wizard.ui") + continue; + // The warn dialog appears to be somewhat broken, at least the + // existing tests for it are currently disabled and it doesn't + // work for me + else if (entry == u"uui/ui/macrowarnmedium.ui") + continue; + // This, for the forumula dialog, are really only available in calc + else if (entry == u"formula/ui/formuladialog.ui" || + entry == u"formula/ui/functionpage.ui" || + entry == u"formula/ui/parameter.ui" || + entry == u"formula/ui/structpage.ui") + { + continue; + } + // Testing this requires hosting an image, or similar, with + // a username+password + else if (entry == u"uui/ui/logindialog.ui") + continue; OUString sEntry(entry); if (!entries.contains(sEntry)) missing.push_back(sEntry); @@ -767,6 +795,7 @@ std::vector<OUString> completeCommonDialogList(const o3tl::sorted_vector<OUStrin }; processCategory(CuiDialogList); processCategory(SfxDialogList); + processCategory(OtherDialogList); return missing; } commit 6cf907c914b3f3fc3e9765f77448211ce3c9656c Author: Caolán McNamara <[email protected]> AuthorDate: Mon Jan 26 21:18:53 2026 +0000 Commit: Caolán McNamara <[email protected]> CommitDate: Tue Feb 24 09:21:20 2026 +0100 make the PDF export warning dialog async Change-Id: I19715102a1db7fb4f3f996cb02d1309caa2d0a4a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/198170 Tested-by: Jenkins CollaboraOffice <[email protected]> Reviewed-by: Miklos Vajna <[email protected]> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/200104 Reviewed-by: Caolán McNamara <[email protected]> diff --git a/filter/source/pdf/pdfinteract.cxx b/filter/source/pdf/pdfinteract.cxx index 26eaaa40da6b..5fe8616d0aa4 100644 --- a/filter/source/pdf/pdfinteract.cxx +++ b/filter/source/pdf/pdfinteract.cxx @@ -60,15 +60,14 @@ sal_Bool SAL_CALL PDFInteractionHandler::handleInteractionRequest( const Referen for( sal_Int32 i = 0; i < nCodes; i++ ) aCodes.insert( static_cast<vcl::pdf::PDFWriter::ErrorCode>(aExc.ErrorCodes.getConstArray()[i]) ); - ImplErrorDialog aDlg(Application::GetFrameWeld(m_xParent), aCodes); - aDlg.run(); + auto xDialog = std::make_shared<ImplErrorDialog>(Application::GetFrameWeld(m_xParent), aCodes); + weld::DialogController::runAsync(xDialog, [](sal_uInt32 /*nResult*/) {}); + bHandled = true; } return bHandled; } - - OUString SAL_CALL PDFInteractionHandler::getImplementationName() { return u"com.sun.star.comp.PDF.PDFExportInteractionHandler"_ustr;
