framework/source/loadenv/loadenv.cxx | 8 -------- 1 file changed, 8 deletions(-)
New commits: commit cb2ac5366d2bfca7123ad1df778bf4b962de42a0 Author: Andras Timar <[email protected]> AuthorDate: Wed Mar 4 12:05:40 2026 +0100 Commit: Miklos Vajna <[email protected]> CommitDate: Wed Mar 4 14:29:50 2026 +0100 framework: don't replace LOKInteractionHandler with QuietInteraction When LOK is active and Silent=true (as in the convert-to path), QuietInteraction was replacing the LOKInteractionHandler. This caused password-protected document requests to be silently aborted instead of firing LOK_CALLBACK_DOCUMENT_PASSWORD, so COOL would see a generic faileddocloading error instead of passwordrequired. The LOKInteractionHandler already handles all interaction types correctly (password, errors, filters), and DialogCancelMode::LOKSilent already prevents dialogs from showing. Remove the replacement. Change-Id: I26a14bf16d5b3472c2d012349ee5b73f983897a7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/200937 Reviewed-by: Miklos Vajna <[email protected]> Tested-by: Jenkins CollaboraOffice <[email protected]> diff --git a/framework/source/loadenv/loadenv.cxx b/framework/source/loadenv/loadenv.cxx index db81c5ce4f3a..d9e3ceaf1988 100644 --- a/framework/source/loadenv/loadenv.cxx +++ b/framework/source/loadenv/loadenv.cxx @@ -298,14 +298,6 @@ void LoadEnv::startLoading(const OUString& sURL, const uno::Sequence<beans::Prop !m_lMediaDescriptor.getUnpackedValueOrDefault(utl::MediaDescriptor::PROP_HIDDEN, false) && !m_lMediaDescriptor.getUnpackedValueOrDefault(utl::MediaDescriptor::PROP_PREVIEW, false); - if( comphelper::LibreOfficeKit::isActive() && - m_lMediaDescriptor.getUnpackedValueOrDefault(utl::MediaDescriptor::PROP_SILENT, false)) - { - rtl::Reference<QuietInteraction> pQuietInteraction = new QuietInteraction(); - m_lMediaDescriptor[utl::MediaDescriptor::PROP_INTERACTIONHANDLER] <<= - uno::Reference<task::XInteractionHandler>(pQuietInteraction); - } - initializeUIDefaults(m_xContext, m_lMediaDescriptor, bUIMode, &m_pQuietInteraction); start();
