On 19/09/12 12:40, Stephan Bergmann wrote: > On 09/18/2012 12:14 AM, Norbert Thiebaud wrote: >> On Mon, Sep 17, 2012 at 11:48 AM, Stephan Bergmann <sberg...@redhat.com> >> wrote:
>> for 2/ >> I propose to create a file 'lo.h', in solenv/inc/ for now... and start >> to bring all source code in conformance... I would have that lo.h >> include sal/config.h and other sal+osl+rtl header that are extremely >> commons (like ustring.hxx). and start to clean-up such include in the >> rest of the code. note: my priority is to bring some order to the >> includes, performance is not the main motivation). >> Having such a header and its use actually enforced give a nice >> platform to do pretty fancy stuff, and to avoid the all to common >> re-invention of the wheel wrt to convenience macros. >> Yes it is a lot of grease-monkey work... but hey I'm used to that... >> and I don't mind.. it's like doing Sudoku to me :-) > > I'm not sure such a lo.h combining inclusion of multiple other header > files would be a good idea. With the constant flux across our code > base, I think aiming at precise, minimal includes is a better approach, > as it helps achieving minimal rebuilds. i fully agree with that; these "convenience headers" tend to become a pain in the long run, and back in the day i've heard regrets from a few developers at Sun about the ones they've added themselves and how they wish they never had done that :) _______________________________________________ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
