Hello Norbert Thiebaud,
I'd like you to reexamine a change. Please visit
https://gerrit.libreoffice.org/708
to look at the new patch set (#2).
Change subject: Fix crash on Mac when a11y in use, and avoid infinite loop,
fdo#47275
......................................................................
Fix crash on Mac when a11y in use, and avoid infinite loop, fdo#47275
The code used static_cast blindly even if the object not necessarily
was of the assumed subclass. Crash followed. Use dynamic_cast instead
to be able to check, like the corresponding code for GTK a11y. After
that fix we then got a nice infinite loop whn an object apparently is
its own parent. Detect that and break out.
Whether accessibility for the affected parts of the GUI actually works
now for its real use cases, no idea. But anything is better than a
crash...
Change-Id: I862234e168db0bd19d185b0f1f73b733b570cac4
Signed-off-by: Norbert Thiebaud <[email protected]>
---
M vcl/aqua/source/a11y/aqua11yfocustracker.cxx
M vcl/aqua/source/a11y/aqua11ywrapper.mm
2 files changed, 20 insertions(+), 2 deletions(-)
git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/08/708/2
--
To view, visit https://gerrit.libreoffice.org/708
To unsubscribe, visit https://gerrit.libreoffice.org/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I862234e168db0bd19d185b0f1f73b733b570cac4
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: libreoffice-3-6
Gerrit-Owner: LibreOffice gerrit bot <[email protected]>
Gerrit-Reviewer: Kohei Yoshida <[email protected]>
Gerrit-Reviewer: Norbert Thiebaud <[email protected]>
Gerrit-Reviewer: Tor Lillqvist <[email protected]>
_______________________________________________
LibreOffice mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/libreoffice
