On Thu, 2012-10-11 at 20:05 +0200, Eike Rathke wrote:
> >     It shouldn't be used in the real code - we should integrate with the
> > glib mainloop that is plugged into VCL :-)
> 
> AFAIK we do that for real code (if things didn't change).

        Ho hum - ideally we should have everything nicely asynchronous and just
return to the VCL mainloop; but - I imagine the existing code structure
can make that hard.

> >     The problem is a careless use of an iteration; if we ran the mainloop
> > until an asynchronous callback quit it - that would be -much- less of a
> > problem :-)
> 
> And we do that :-)

        Nice :-)

> And we don't do it ;-)
> 
>     while (!pImpl->mbAccountManagerReadyHandlerInvoked)
>             g_main_context_iteration( NULL, TRUE);

        Good; that looks safe enough :-) I forgot you'd cleaned all of that up.

        Thanks !

                Michael.

-- 
michael.me...@suse.com  <><, Pseudo Engineer, itinerant idiot

_______________________________________________
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Reply via email to