Hi,

Quoting David Tardon <[email protected]>:

Hi,

On Tue, Oct 16, 2012 at 11:38:28AM +0200, Stephan Bergmann wrote:
On 10/16/2012 11:14 AM, [email protected] wrote:
>the easiest way to sort this out would be to add a check in configure.in
>for that:
>if --with-lang="en-US" then fail or unset WITH_LANG, right?

No, the easiest thing should be to fix
solenv/gbuild/ExtensionTarget.mk.  I understand that the other David
is doing that.

Maybe not the easiest, but the most correct :-)
;-)
ah, well, if we are talking about the correct way ...
then we shouldn't play these games with such a construct
MODULE_FOO_LANGS := en-US $(filter-out en-US,$(gb_WITH_LANG))
any more but introduce a new variable gb_WITH_LANG_OR_DEFAULT
and use it in all places instead.

I mentioned it already in comment in readlicense_oo module during gbuildification ...
but didn't do it myself ;-)

http://cgit.freedesktop.org/libreoffice/core/tree/readlicense_oo/CustomTarget_readme.mk#n15

Regards
David

_______________________________________________
LibreOffice mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Reply via email to