On Thu, Nov 15, 2012 at 5:24 AM, Enrico Weigelt <[email protected]> wrote: > Hi folks, > > I'm currently working on removing unused functions (mentioned > in unused.easy). Should I do it one by one with separate commits > or in one big commit ? > > An big commit would make it easier/quicker for me (as I dont > need so many rebuilds), but perhaps could make review a bit > harder.
and increase the odd that the patch would get rejected for removing something that _is_ really used (albeit not on linux) the unused.easy thing is parsing a linux build... so there may be some false positive there... SO I would suggest smaller patch (rebuilding should not be that painfull, if you stay on the same position on master and just do incremental build... Norbert _______________________________________________ LibreOffice mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/libreoffice
