Hello all, On Fri, Jan 11, 2013 at 8:44 PM, Pierre-Eric Pelloux-Prayer (via Code Review) <[email protected]> wrote: > I have submitted a patch for review: > https://gerrit.libreoffice.org/1646 > doc export: add unit test for bug i106749
IMHO it's great to have many unit tests as possible :), but I wonder ... > diff --git a/sw/qa/extras/ww8export/data/new-page-styles.doc > b/sw/qa/extras/ww8export/data/new-page-styles.doc > new file mode 100644 > index 0000000..c3886fd > --- /dev/null > +++ b/sw/qa/extras/ww8export/data/new-page-styles.doc Do we have a license to use this file? (no offense of course! :) Or in general, what about any bugzilla attachments? Because it seems you have taken this file from apache bugzilla ... What about another patch at https://gerrit.libreoffice.org/1644, doc export: add unit test for fdo#56513 ? It's an attachment from Luke Deller, which we already have a license statement from him. Does the license statement include this file? Does this differ to the first case? or is this file simple enough that it doesn't have copyright? OK, maybe I'm wrong, because I'm not a lawyer, but ... :) Michael Meeks, since you are rebasing the code from apache, do you have any opinions? Best Regards, -- Korrawit Pruegsanusak _______________________________________________ LibreOffice mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/libreoffice
