Re: [Libreoffice-commits] core.git: 3 commits - android/sdremote l10ntools/source

[Thorsten Behrens]

gerrit wrote:
> index 71909d9..26aabcb 100644
> --- a/l10ntools/source/stringmerge.cxx
> +++ b/l10ntools/source/stringmerge.cxx
> @@ -161,6 +161,7 @@ void StringParser::Merge(
>              {
>                  OString sNewText;
>                  pEntrys->GetText( sNewText, STRING_TYP_TEXT, m_sLang );
> +                sNewText = 
> sNewText.replaceAll("\"",""").replaceAll("\\\\\"","\\\"").replaceAll("\'","'").replaceAll("\\\\\'","\\\'");
>                  xmlNodeSetContent(
>                      pCurrent,
>                      xmlEncodeSpecialChars( NULL,
>
This one is actually broken - xmlNodeSetContent already does the
necessary escaping of entities, in this case " etc gets turned
into ". Updated the Impress Remote regardless (as having
localized UI there is still worthwhile), will look after a proper fix
tomorrow.

Cheers,

-- Thorsten

signature.asc
Description: Digital signature

_______________________________________________
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice