On Mon, Feb 18, 2013 at 5:56 AM, Eike Rathke <[email protected]> wrote: > Hi, > > On Friday, 2013-02-15 14:30:33 -0600, Norbert Thiebaud wrote: > >> -2 is effectively a veto because it is a sticky state that >> remain even if a new version of the patch is uploaded... so as long as >> there is a -2 one cannot Submit the patch, short of hacking gerrit or >> pushing the patch directly to master, by-passsing gerrit-review >> altogether. > > And of course the "clean" solution, a -2 can also be reverted by the > reviewer who issued the -2 if the follow-up patch addresses the > concerns.
If the concerns are addressable (other than by 'do not do that') then that should have been a -1 to start with which is enough to block _that_ version of the patch from going through. Norbert _______________________________________________ LibreOffice mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/libreoffice
