On 03/08/2013 08:47 PM, Arnaud Versini wrote:
My mistake, the good way I think is %q, not %b, is it correct or not ?
While that would solve the second part of the problem at least for Linux (as %q is not Posix) I guess, the much simpler and more idiomatic solution is to properly quote all uses of ${URI_ENCODE} in the script as "${URI_ENCODE}".
And, for the first part of the problem, you still need to properly quote the argument to dirname, as given below.
Stephan
2013/3/8 Stephan Bergmann <[email protected] <mailto:[email protected]>> On 03/08/2013 05:32 AM, Fridrich Strba (via Code Review) wrote: Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.__org/2588 <https://gerrit.libreoffice.org/2588> Approvals: Fridrich Strba: Verified; Looks good to me, approved But how does diff --git a/shell/source/unix/misc/__senddoc.sh b/shell/source/unix/misc/__senddoc.sh index 0ff1594..a2c53fd 100644 --- a/shell/source/unix/misc/__senddoc.sh +++ b/shell/source/unix/misc/__senddoc.sh @@ -18,6 +18,7 @@ # URI_ENCODE="`dirname $0`/uri-encode" +URI_ENCODE=$(printf "%b" "$(URI_ENCODE)") FOPTS="" sd_platform=`uname -s` fix <https://bugs.freedesktop.org/__show_bug.cgi?id=60701 <https://bugs.freedesktop.org/show_bug.cgi?id=60701>> "Send Document as email fails, when application is installed to a directory with a space" in any way? The solution should be to properly quote the argument to dirname, URI_ENCODE=`dirname "$0"`/uri-encode What the printf '%b' does is break things if the path to LO contains character sequences like "\n".
_______________________________________________ LibreOffice mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/libreoffice
