Julien Nabet wrote:
> I noticed several things:
> 1) we could replace "if (pText1)" by "if (pNewText)". Of course if blocks
> must be changed
> 2) if pText1 corresponds to a new OutlinerParaObject and !pText, it seems
> there's a leak
>
Yeps.

> 3) why pObj->ActionChanged() and  ImpShowPageOfThisObject() are always
> called ?
> 
I would not suggest relying on that - this code has some serious 15+
years of bugfix sedimentation behind it. If you've played some
multiple hours with your fix in, and understood the code flow, go for
it - otherwise, don't take chances. ;)

Cheers,

-- Thorsten

Attachment: signature.asc
Description: Digital signature

_______________________________________________
LibreOffice mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Reply via email to