Hi Michael, On 25/03/13 12:27, Michael Meeks wrote: > Hi Javier, > > Thanks for your great work on the wizards here :-) > > In general I think it would be really much better if we could get > multiple commits to a gerrit branch without spamming the list with one > E-mail per commit :-) I'm not sure if that's a gerrit 'feature' or if > it's some configuration issue we have or ...
Yes :) sorry about that. It was only for the first push; I had a big commit before, but I thought it was easier to review it that way. I was not sure what would be the result, in terms of gerrit process. The branch I've just pushed is the minimum required to just launch the wizard, which I think was an interesting point to start the review. Of course, next patches wont be like that, but specific changes for specific features and bugs. Anyway, again, sorry for the noise. > > Norbert - how does that work ? if I push a branch with a dozen new > commits - do we get a single set of commits / branch to review in gerrit > or a dozen spams mails etc. ? :-) > > Javier if the latter - then I guess some use of: > > git rebase -i origin/master > > could be used (assuming you're rebased to origin/master) to squash the > individual adds together into a single commit (?). > Yes, as I said, I thought on doing it, but somehow I was afraid it was going to be a huge patch, harder to review. The problem is that the Webwizard is by far the biggest one, involving a lot of files and classes. > Anyhow - great to see this arriving. > Actually, I have around 20 more commits to push later, as soon as someone, perhaps Xisco, review the current branch and after we agree on the specific integration issues we have now woth the Agenda wizard. Also, just for your information, I've got almost a fully implemented wizard in my local branch, just pending of revision. _______________________________________________ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
