Janit Anjaria wrote: > I am hereby submitting my patch for review on the bug/feature which i had > worked long back which solves the problem where the comboboxes now do > appear when the toolbar is vertical. > Hi Janit,
the patch contains a lot of changes ala
if ( eAlign == WINDOWALIGN_TOP )
{
- rLeft = borderwidth+dragwidth;
+ rLeft = borderwidth+dragwidth-150;
rTop = borderwidth;
- where do those numbers come from; as Astron points out, it breaks
more than it fixes?
Also, please remove unrelated whitespace / formatting changes, ala
{
pThis->mpData->mbAssumeDocked = sal_True; // force non-floating
mode during calculation
- ImplCalcBorder( WINDOWALIGN_LEFT, nLeft, nTop, nRight, nBottom,
pThis );
+ ImplCalcBorder( WINDOWALIGN_LEFT, nLeft, nTop, nRight, nBottom,
pThis );
, or submit it separately (the example above though really makes
matters worse, not better).
Please spend a bit of time on reviewing / cleaning up your patch
submissions *before* mailing them out. This increases your chances of
getting useful and timely feedback.
Cheers,
-- Thorsten
signature.asc
Description: Digital signature
_______________________________________________ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
