Hi Miklos,

Please, in the future, at least build-test your patch.
Regrets for the same.
This was the first time I didn't buid test as I thought I merely replaced
some 'compareTo' by '==' so I 'assumed' it should not be a problem. I
ensure you, this was my last time I did this mistake.

 For now, I just fixed it for you, and pushed to master.
Thanks a lot :)

Also, please use the "[PATCH]" string in the subject of your mail, or
simply push the patch to gerrit:
I've been in habit of pushing my patches to gerrit and I'd done it many
times ago. It was just some ssh or ipmc access restriction from my server
side that I could not push to gerrit. Anyways I'll surely take care of the
fact, to prepend [PATCH] in future if I plan to mail my patch.

Thanks for guidance and patch review. :-)

Regards
Prashant
_______________________________________________
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Reply via email to