On Thu, 2013-10-24 at 10:38 +0300, Maxim Monastirsky wrote: > Hi All, > Starting with 4.1 csv files with xls extension & also tsv files are opened > using > writer instead of calc, when opening from the start center or from cli > without > '--calc'. While it's clear that the tsv part should be fixed (BTW it's a > trivial fix [1]), I'm not sure about csv files with xls extension. Users > shouldn't expect that after changing the file extension to some random > extension, it still would be recognized as a csv by default. But on the other > hand the fact that some user opened a bug for it, might indicate that some > app\web app generates such files. So what do you think? Should it be fixed, > or > should we close the bug as WONTFIX? > > The relevant bug reports are: > https://bugs.freedesktop.org/show_bug.cgi?id=68903 (csv with .xls extension) > https://bugs.freedesktop.org/show_bug.cgi?id=69290 (tsv)
Well, when the app name is not given, the current detection code relies on the extension to decide which app to open the file with (as you already noticed). I believe we associate "csv" to Calc in this case, http://cgit.freedesktop.org/libreoffice/core/tree/filter/source/textfilterdetect/filterdetect.cxx#n75 so I would say it's also reasonable to associate "tsv" and "xls" to Calc as well. Feel free to propose a patch for this and push it to gerrit. It should be a very easy fix. Kohei _______________________________________________ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
