animations/source/animcore/animcore.cxx | 8 ++++---- animations/source/animcore/targetpropertiescreator.cxx | 6 +++--- 2 files changed, 7 insertions(+), 7 deletions(-)
New commits: commit f72ba183205634fb8490b1632059d3bec21901b9 Author: Alexander Wilms <f.alexander.wi...@gmail.com> Date: Tue Feb 25 17:16:36 2014 +0100 Remove visual noise from animations Change-Id: I45b8019bebf6530136642bf34be829d7e26e2454 Reviewed-on: https://gerrit.libreoffice.org/8228 Reviewed-by: Caolán McNamara <caol...@redhat.com> Tested-by: Caolán McNamara <caol...@redhat.com> diff --git a/animations/source/animcore/animcore.cxx b/animations/source/animcore/animcore.cxx index b199af3..6259271 100644 --- a/animations/source/animcore/animcore.cxx +++ b/animations/source/animcore/animcore.cxx @@ -99,11 +99,11 @@ using namespace ::com::sun::star::animations::AnimationNodeType; namespace animcore { -// ==================================================================== + typedef ::std::list< Reference< XAnimationNode > > ChildList_t; -// ==================================================================== + class AnimationNodeBase : public XAnimateMotion, public XAnimateColor, @@ -350,7 +350,7 @@ private: ChildList_t maChildren; }; -// ==================================================================== + class TimeContainerEnumeration : public ::cppu::WeakImplHelper1< XEnumeration > { @@ -402,7 +402,7 @@ Any SAL_CALL TimeContainerEnumeration::nextElement() return makeAny( (*maIter++) ); } -// ==================================================================== + Sequence< Type >* AnimationNode::mpTypes[] = { NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL }; Sequence< sal_Int8 >* AnimationNode::mpId[] = { NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL }; diff --git a/animations/source/animcore/targetpropertiescreator.cxx b/animations/source/animcore/targetpropertiescreator.cxx index 04cc32f..f31cddc5 100644 --- a/animations/source/animcore/targetpropertiescreator.cxx +++ b/animations/source/animcore/targetpropertiescreator.cxx @@ -143,13 +143,13 @@ namespace animcore // TODO(P2): Maybe a better hash function would be to // spread mnParagraphIndex to 32 bit: a0b0c0d0e0... Hakmem // should have a formula. - // + // Yes it has: // x = (x & 0x0000FF00) << 8) | (x >> 8) & 0x0000FF00 | x & 0xFF0000FF; // x = (x & 0x00F000F0) << 4) | (x >> 4) & 0x00F000F0 | x & 0xF00FF00F; // x = (x & 0x0C0C0C0C) << 2) | (x >> 2) & 0x0C0C0C0C | x & 0xC3C3C3C3; // x = (x & 0x22222222) << 1) | (x >> 1) & 0x22222222 | x & 0x99999999; - // + // Costs about 17 cycles on a RISC machine with infinite // instruction level parallelism (~42 basic // instructions). Thus I truly doubt this pays off... @@ -421,7 +421,7 @@ namespace animcore // TODO(F1): Maybe limit functor application to main sequence // alone (CL said something that shape visibility is only // affected by effects in the main sequence for PPT). - // + // OTOH, client code can pass us only the main sequence (which // it actually does right now, for the slideshow implementation). aFunctor( xRootNode );
_______________________________________________ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits