sc/source/ui/view/formatsh.cxx | 1 + sd/source/ui/view/drviews2.cxx | 1 + svtools/source/brwbox/ebbcontrols.cxx | 2 ++ sw/source/core/crsr/trvltbl.cxx | 3 +++ sw/source/uibase/shells/basesh.cxx | 1 + 5 files changed, 8 insertions(+)
New commits: commit 44202fed1fcb6b8d3523fd9e7bebf47f02fcd6d2 Author: Caolán McNamara <caol...@redhat.com> Date: Thu Jun 5 21:02:41 2014 +0100 coverity#1213246 Dereference null return value Change-Id: I682a1e912728d6e52df258c7528e358f2883b323 diff --git a/sw/source/core/crsr/trvltbl.cxx b/sw/source/core/crsr/trvltbl.cxx index e581c7a..5d7a647 100644 --- a/sw/source/core/crsr/trvltbl.cxx +++ b/sw/source/core/crsr/trvltbl.cxx @@ -63,6 +63,9 @@ bool SwCrsrShell::GoNextCell( bool bAppendLine ) { if ( !pTblNd ) pTblNd = IsCrsrInTbl(); + assert (pTblNd); + if (!pTblNd) + return false; pTableBox = & pTableBox->FindEndOfRowSpan( pTblNd->GetTable(), (sal_uInt16)(pTableBox->getRowSpan() + pCrsr->GetCrsrRowSpanOffset() ) ); pTableBoxStartNode = pTableBox->GetSttNd(); commit 64df417cdb20466c823de0251ad2aa3a80833f28 Author: Caolán McNamara <caol...@redhat.com> Date: Thu Jun 5 20:58:58 2014 +0100 coverity#1019354 Missing break in switch, assuming intentional Change-Id: I4dd2f68e8712a2c76797a33c54d1baf69975830f diff --git a/sd/source/ui/view/drviews2.cxx b/sd/source/ui/view/drviews2.cxx index 3959c11..bd7c4bf 100644 --- a/sd/source/ui/view/drviews2.cxx +++ b/sd/source/ui/view/drviews2.cxx @@ -1265,6 +1265,7 @@ void DrawViewShell::FuTemporary(SfxRequest& rReq) case SID_CAPTUREPOINT: // negative value to signal call from menu maMousePos = Point(-1,-1); + // fall-through case SID_SET_SNAPITEM: { SetCurrentFunction( FuSnapLine::Create(this, GetActiveWindow(), mpDrawView, GetDoc(), rReq) ); commit b787ed773493b01f34e8dfb66f74da17147d82a3 Author: Caolán McNamara <caol...@redhat.com> Date: Thu Jun 5 20:56:34 2014 +0100 coverity#705317 Missing break in switch, assuming intentional Change-Id: I9bd2ffc1ebf22f6f5ea61a448b7c9e83e724fa4d diff --git a/sw/source/uibase/shells/basesh.cxx b/sw/source/uibase/shells/basesh.cxx index e9aa004..0bd7d8f 100644 --- a/sw/source/uibase/shells/basesh.cxx +++ b/sw/source/uibase/shells/basesh.cxx @@ -1955,6 +1955,7 @@ void SwBaseShell::ExecTxtCtrl( SfxRequest& rReq ) nScripts = SvtLanguageOptions::GetScriptTypeOfLanguage( nInputLang ); } } + // fall-through case SID_ATTR_CHAR_POSTURE: case SID_ATTR_CHAR_WEIGHT: { commit 94e2459cd89320cc55119fbd3ce1651ccd376c3e Author: Caolán McNamara <caol...@redhat.com> Date: Thu Jun 5 20:48:13 2014 +0100 coverity#705245 Missing break in switch, assuming intentional Change-Id: I2ac6acde603c89c5b7736ec7f1a1b42b28726827 diff --git a/svtools/source/brwbox/ebbcontrols.cxx b/svtools/source/brwbox/ebbcontrols.cxx index 9587207..13988ce 100644 --- a/svtools/source/brwbox/ebbcontrols.cxx +++ b/svtools/source/brwbox/ebbcontrols.cxx @@ -116,6 +116,7 @@ namespace svt // drop down the list box else if (rEvt.GetKeyCode().IsMod2() && rEvt.GetKeyCode().GetCode() == KEY_DOWN) return false; + // fall-through case KEY_PAGEUP: case KEY_PAGEDOWN: case KEY_RETURN: @@ -213,7 +214,7 @@ namespace svt else if (rEvt.GetKeyCode().IsMod2() && rEvt.GetKeyCode().GetCode() == KEY_DOWN) return false; - //fall-through + // fall-through case KEY_PAGEUP: case KEY_PAGEDOWN: if (rBox.IsTravelSelect()) commit 0017cafc9d6c778a404fd71d5d1dccb1a02e7de9 Author: Caolán McNamara <caol...@redhat.com> Date: Thu Jun 5 20:47:38 2014 +0100 coverity#705243 Missing break in switch, assuming intentional Change-Id: I4882ba5028e45528cafc1170bc4de6c3a2ea7a12 diff --git a/svtools/source/brwbox/ebbcontrols.cxx b/svtools/source/brwbox/ebbcontrols.cxx index c1b865c..9587207 100644 --- a/svtools/source/brwbox/ebbcontrols.cxx +++ b/svtools/source/brwbox/ebbcontrols.cxx @@ -213,6 +213,7 @@ namespace svt else if (rEvt.GetKeyCode().IsMod2() && rEvt.GetKeyCode().GetCode() == KEY_DOWN) return false; + //fall-through case KEY_PAGEUP: case KEY_PAGEDOWN: if (rBox.IsTravelSelect()) commit 9009dfb67bd0c6f184cb89c251618427a0b655ca Author: Caolán McNamara <caol...@redhat.com> Date: Thu Jun 5 20:45:22 2014 +0100 coverity#705214 Missing break in switch, assuming intentional Change-Id: I6c62c7fc18dc43504ff65cece55ba189bf59aa60 diff --git a/sc/source/ui/view/formatsh.cxx b/sc/source/ui/view/formatsh.cxx index 045ddf0..a0817d8 100644 --- a/sc/source/ui/view/formatsh.cxx +++ b/sc/source/ui/view/formatsh.cxx @@ -421,6 +421,7 @@ void ScFormatShell::ExecuteStyle( SfxRequest& rReq ) } } } + //fall-through case SID_STYLE_EDIT: case SID_STYLE_DELETE: case SID_STYLE_HIDE:
_______________________________________________ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits