On Thursday, April 17, 2014 09:44:52 AM Markos Chandras wrote: > On 04/16/2014 09:55 PM, Paul Moore wrote: > > Replace the "+all" architecture tokens in the test files with the > > "+all_le" and "+all_be" tokens to represent all the little endian and > > big endian architectures respectively. > > > > Signed-off-by: Paul Moore <[email protected]> > > --- > > > > src/db.c | 2 +- > > tests/16-sim-arch_basic.tests | 12 ++++++------ > > tests/23-sim-arch_all_basic.tests | 14 +++++++------- > > tests/regression | 9 ++++++--- > > 4 files changed, 20 insertions(+), 17 deletions(-) > > > > diff --git a/src/db.c b/src/db.c > > index 8694bac..e3086bd 100644 > > --- a/src/db.c > > +++ b/src/db.c > > @@ -668,7 +668,7 @@ int db_col_db_remove(struct db_filter_col *col, > > uint32_t arch_token)> > > } > > col->filters[--col->filter_cnt] = NULL; > > > > - if (col->filters > 0) { > > + if (col->filter_cnt > 0) { > > Hi Paul, > > is this change intentional? Maybe it should belong to a previous patch?
Your are right on both counts: the change is intentional, but it should have been in previous patch. Ooops :) At least it is correct now, sorry for the confusion. > > diff --git a/tests/regression b/tests/regression > > index 4901539..b83e8a2 100755 > > --- a/tests/regression > > +++ b/tests/regression > > @@ -21,7 +21,8 @@ > > > > # along with this library; if not, see <http://www.gnu.org/licenses>. > > # > > > > -GLBL_ARCH_SUPPORT="x86 x86_64 x32 arm mipsel" > > +GLBL_ARCH_LE_SUPPORT="x86 x86_64 x32 arm mipsel" > > +GLBL_ARCH_BE_SUPPORT="mips" > > > > GLBL_SYS_ARCH="../tools/scmp_arch_detect" > > GLBL_SYS_RESOLVER="../tools/scmp_sys_resolver" > > > > @@ -344,8 +345,10 @@ function run_test_bpf_sim() { > > > > if [[ "${testarch:0:1}" == "+" ]]; then > > > > # run the tests on the specified architecture(s) > > simarch_list="${testarch:1}" > > > > - if [[ "$simarch_list" == "all" ]]; then > > - simarch_list="$GLBL_ARCH_SUPPORT" > > + if [[ "$simarch_list" == "all_le" ]]; then > > + simarch_list="$GLBL_ARCH_LE_SUPPORT" > > + elif [[ "$simarch_list" == "all_be" ]]; then > > + simarch_list="$GLBL_ARCH_BE_SUPPORT" > > > > fi > > > > elif [[ "$testarch" != "all" ]] && [[ "$testarch" != "$arch" ]]; then > > > > # only run tests that match the current architecture > > Thanks. I had something similar locally. I will see if I can add a new > test for MIPS BE now. Great, looking forward to it. -- paul moore security and virtualization @ redhat ------------------------------------------------------------------------------ Learn Graph Databases - Download FREE O'Reilly Book "Graph Databases" is the definitive new guide to graph databases and their applications. Written by three acclaimed leaders in the field, this first edition is now available. Download your free book today! http://p.sf.net/sfu/NeoTech _______________________________________________ libseccomp-discuss mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/libseccomp-discuss
