With the attached patch, I don't have any errors/warnings on: - MinGW (gcc v4.4.0) - Linux debian 2.6.26-2-686 (gcc v4.3.2) - Mac OS X ProductVersion: 10.5.7 BuildVersion: 9J61 (gcc v4.0.1)
I would be happy if someone could try it out on Visual Studio... 2009/7/28 Daniel Stenberg <[email protected]> > On Tue, 28 Jul 2009, Steven Van Ingelgem wrote: > > -Werror is of course your choice. libssh2 does not build warning free so I >>> wouldn't use that... >>> >> > It should build free of warnings ;-) >> > > Yes I agree. It is mentioned as a TODO item, but the API is in fact > designed in such a way that can't compile warning-free with strict compiler > options. It mixes object and function pointers. We can't fix that without > breaking the ABI so it won't be done completely until the next soname bump. > > This is how MinGW defines "FD_SET": >> >> typedef u_int SOCKET; >> >> #define FD_SETSIZE 64 >> >> typedef struct fd_set { >> u_int fd_count; >> SOCKET fd_array[FD_SETSIZE]; >> } fd_set; >> > > Right, so this is then related to how we use 'int' for sockets internally > when we should rather switch to a separate type to deal with systems having > different signedness of the type. I've added a mention in the TODO for this. > If you're interested in working on this I'll be happy to get a patch to > apply after 1.2... > > > -- > > / daniel.haxx.se > _______________________________________________ > libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel >
patch.patch
Description: Binary data
_______________________________________________ libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel
