Bugs item #2903167, was opened at 2009-11-24 15:17
Message generated for change (Tracker Item Submitted) made by nobody
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=703942&aid=2903167&group_id=125852

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Nobody/Anonymous (nobody)
Assigned to: Nobody/Anonymous (nobody)
Summary: Error message is not updated on failure

Initial Comment:
Error message in LIBSSH2_SESSION is not updated on failure in some places.  For 
example (libssh2-1.2.2): src/userauth.c line 299 and line 1355 - no calls to 
libssh2_error().  When using libssh2_session_last_error(), I get messages from 
previous failure.  As a result, my own error messages look like the following 
(error messages from libssh2 are "quoted"):

authentication by password failed: "Would block requesting userauth list"; 
authentication by keyboard-interactive failed: "Would block requesting userauth 
list".

authentication by public key failed: "Username/PublicKey combination invalid"; 
authentication by password failed: "Username/PublicKey combination invalid".

Just adding function to clear current error message from session might be fine. 
 Then it would be possible to save error message from one call, clear error 
message in session, then call another function and save its error message.  
Missing error messages can be treated as some generic failure.

Observed with non-blocking API on windows vista with custom build of 
libssh2-1.2.1 using Visual Studio 2005.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=703942&aid=2903167&group_id=125852
_______________________________________________
libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel

Reply via email to