On Tue, 31 Aug 2010, Uli Zappe wrote:

Now we only need to figure out the right fix...

If the whole purpose of this if clause is as unclear as it is to me, you could probably simply remove it completely. Other than that, I can see no harm if the < 32 check remains and only the > 127 check is removed.

The purpose of that code is to make sure we receive a valid SCP protocol.

And yes, I was a bit confused about how UTF-8 looks like but I agree that the
126 check should be removed. I've committed a fix for this now.

Thanks for the report!

--

 / daniel.haxx.se
_______________________________________________
libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel

Reply via email to