On 9 February 2012 13:38, Peter Stuge <pe...@stuge.se> wrote: > Alexander Lamaison wrote: >> >> >> + filep->data_left = rc32 - buffer_size; >> >> > >> >> > Doesn't this lose the bytes that we received from transport but which >> >> > do not fit into the buffer given to us by the user? >> >> >> >> Not unless it did so before. >> > >> > Sure. Look at the logic. data_left is being set to a smaller number >> > of bytes than actually received from transport. Where do the >> > remaining bytes go? >> >> Right. That's its purpose, isn't it? It stores how big the >> leftovers are. > > Yes, you're of course right. Thanks for the patience. Looking forward > to the patch without loop! (Is there a reason not to squash it > together with your previous changes?)
In two words, git bisect. The smaller the change, the more precisely we can attribute the blame should something go wrong. Alex _______________________________________________ libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel