On 02/28/2012 03:21 AM, Henrik Nordström wrote:
> mån 2012-02-27 klockan 20:58 -0700 skrev Steven Dake:
>> 11.4.  Reserved Messages
>>
>>    An implementation MUST respond to all unrecognized messages with an
>>    SSH_MSG_UNIMPLEMENTED message in the order in which the messages were
>>    received.  Such messages MUST be otherwise ignored.  Later protocol
>>    versions may define other meanings for these message types.
>>
>>       byte      SSH_MSG_UNIMPLEMENTED
>>       uint32    packet sequence number of rejected message
>>
>>  
>> +        case SSH_MSG_UNIMPLEMENTED:
>> +            LIBSSH2_FREE(session, data);
>> +            session->packAdd_state = libssh2_NB_state_idle;
>> +            return 0;
>> +
> 
> Err.. it's an error and needs to be dealt with. If not then the
> application will not know that the request failed.
> 
> Regards
> Henrik
> 


Possible but at the moment the error isn't captured by any API resulting
in a packet leak when this happens.

I am not quite sure how to return an error code in this condition, so
not certain how to propose such a patch.

Regards
-steve
_______________________________________________
libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel

Reply via email to