On Wed, 27 Nov 2013, Jiří Ševčík wrote:

For monitoring of the total count of transferred data during the connection
tto the server, we created patch that added two functions:
libssh2_session_recv_data(LIBSSH2_SESSION *session) and
libssh2_session_recv_data(LIBSSH2_SESSION *session).

In this patch was added to session structure two counters (datatype long
long)
Incrementation of these counters is performed at
_libssh2_recv/_libssh2_send.
where was added next input parameter - current session.

My question: is this patch correct and applicable and could't it cause any problems in future?

Thanks for your contribution.

At a quick glance, this seems to break libssh2_session_callback_set's LIBSSH2_CALLBACK_SEND and LIBSSH2_CALLBACK_RECV option since you change the prototype of the function used to send and receive.

--

 / daniel.haxx.se
_______________________________________________
libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel

Reply via email to