>> --- include/libssh2.h        4 Nov 2006 19:30:31 -0000       1.60
>> +++ include/libssh2.h        23 Nov 2006 17:06:42 -0000
>> @@ -172,8 +172,8 @@ typedef struct _LIBSSH2_POLLFD {
>>              LIBSSH2_LISTENER *listener; /* Read polls only -- are inbound 
>> connections waiting to be accepted? */
>>      } fd;
>>
>> -    unsigned long events; /* Requested Events */
>> -    unsigned long revents; /* Returned Events */
>> +    unsigned long ssh2events; /* Requested Events */
>> +    unsigned long ssh2revents; /* Returned Events */
>> } LIBSSH2_POLLFD;
> 
> As this is in include/libssh2.h, are applications expected to access
> those fields? If so the patch would create API problems obviously, but
> it would be tricky to avoid that.
> 
> -Tor (aka tor2)
> 
Yep, calling apps are expected to set events and review revents similar 
to syscalls to poll().  This will definately cause a problem for 
existing applications using the libssh2_poll() API, but it's not a major 
one and can be fixed in these few applications through the use of an 
ifdef/define.

I'm inclined to say this break is okay while we're in beta versions so 
long as it's noted in large type both in the release notes and the 
manual page on the wiki.

-Sara

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
libssh2-devel mailing list
libssh2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/libssh2-devel

Reply via email to