[EMAIL PROTECTED] wrote: > Daniel Stenberg <[EMAIL PROTECTED]> writes: > >> On Thu, 16 Nov 2006, Simon Josefsson wrote: >> >>> This removes the LIBSSH2_CRYPT_METHOD_FLAG_EVP flag (and the entire flag >>> variable, although that part is not essential) and the flag's semantic. >>> >>> This moves some EVP_* calls into crypt.c, which is the first step towards >>> isolating all crypto functions and then replacing them. >> I'm in favour of committing this as we need to start separating the >> underlying implementation from what we use within the lib. > > I've installed the patch below. It moves most (maybe all) symmetric > crypto calls to OpenSSL into crypt.c. > Looks fantastic, but could I ask a couple things before you commit?
* spaces/tabs: I know you have feelings about this, and we can still discuss changing the indenting standard to spaces. But until the group comes up with a consensus, can we stick to consistency? * Braces on one-line if statements: Another religious topic, but I certainly feel they make the code more maintainable. > I'm going on vacation tomorrow, but when I come back in January, I > intend to work on some glue-mechanism that allows libssh2 to use > either openssl or libgcrypt, decidable at configure-time. > That'll be fantastic. -Sara ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ libssh2-devel mailing list libssh2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/libssh2-devel
