>> Also, how would you feel about supporting larger read sizes 
>> than 32k? I took off the artificial cap for SFTP to test it 
>> out, but the packets are still maxing out at 64k (I haven't 
>> checked why yet).  I think supporting up to 100k or so 
>> would be nice, and the spec declares that the current max 
>> size only be supported, not that it must be the largest 
>> size supported.

Hi,

There are couple of reasons why 64k buffer is the largest
possible value.

TCP's maximum window size is 64k (ignoring TCP window scaling), 
larger chunks will get segmented. Thus it really makes no sense 
to send larger data chunks. Also the SFTP server might limit 
the window to a smaller size. The maximum window size is 
negotiated in SSH/SFTP.

And one remark regarding socket error situations.

I am currently using version 0.14 and SFTP does not make any
difference whether the packet reading failed with EBADF, EIO, 
ETIMEDOUT or ENOTCONN. It always emits just a "timed out" error.

This is quite annoying debugging wise.

Hopefully the new blocking/non-blocking scheme has taken this into
account and has more sane error messages.

Also, I would *love* to have run-time diagnostics. Performance wise
a diagnostic macro would not cause significant losses. Inlining an
if-statement would ease the debugging of systems in production. 

br,

/jUSSi
-- 
perl -e '[EMAIL PROTECTED],0112,0,0],[0,0101,0,0],
[0,0120,0,0],[0,0110,0,0]];$[=256/8-0x1D;
print(chr(@{$_}[+($[+1-1+1)]))for(@[EMAIL PROTECTED]);'

Disclaimer: This message and any attachments thereto are intended solely for
the addressed recipient(s) and may contain confidential information. If you
are not the intended recipient, please notify the sender by reply e-mail and
delete the e-mail (including any attachments thereto) without producing,
distributing or retaining any copies thereof. Any review, dissemination or
other use of, or taking of any action in reliance upon, this information by
persons or entities other than the intended recipient(s) is prohibited.
Thank you.

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
libssh2-devel mailing list
libssh2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/libssh2-devel

Reply via email to