On Wed, 1 Oct 2008, Paul Thomas wrote:
> Could I get an account on the wiki so that I can update it? I'd like to at
> least update the reference for the pty resizing functionality that I added
> in.
Please update docs in the docs we have in the source CVS tree! The wiki is
outdated for that anyway.
And also, your latest src/channel.c commits have several faults:
1) they don't build on Linux (see below)
2) they contain // comments and they are not welcome in our code!
3) your code is longer than 80 columns, please shorten the lines
4) you added CRLF newlines in the code, don't do that
Build errors with current CVS:
gcc -DHAVE_CONFIG_H -I../include -I../src -DLIBSSH2DEBUG -g -I/usr/include -g
-W -Wall -Wwrite-strings -pedantic -Wpointer-arith -Wnested-externs -Winline
-Wmissing-prototypes -Wmissing-declarations -Wundef -Wno-long-long
-Wsign-compare -Wfloat-equal -Wno-format-nonliteral -Wendif-labels
-Wstrict-prototypes -Wdeclaration-after-statement -MT channel.lo -MD -MP -MF
.deps/channel.Tpo -c channel.c -o channel.o
channel.c: In function 'libssh2_channel_request_pty_size_ex':
channel.c:941: warning: unused variable 'data_len'
channel.c:939: warning: unused variable 'reply_codes'
channel.c:938: warning: unused variable 'data'
channel.c:1524:3: warning: C++ style comments are not allowed in ISO C90
channel.c:1524:3: warning: (this will be reported only once per input file)
channel.c: In function 'libssh2_channel_read_ex':
channel.c:1525: error: expected identifier before '(' token
channel.c:1525: error: expected statement before ')' token
--
/ daniel.haxx.se
-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
libssh2-devel mailing list
libssh2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/libssh2-devel
