On Thu, 20 Nov 2008, Peter Stuge wrote: >> I was mostly curious if anyone has something to say about the general >> approach this uses, > > Will it actually work for all cases? Mabe that's what you may mean by > finishing it up. :)
That's exactly what I meant. I just casually browsed the patch and I too thought it seemed to miss some cases, but assuming the approach is fine we can commit what we have and then work on making sure all cases are cought and dealt with appropriately. > I'm thinking that sometimes it may be appropriate to wait for both reads and > writes, but as long as libssh2 keeps track I think this approach looks just > fine.. Yeps, and thus this function needs to be able to return individual bits for the directions so that they can be read, write or read+write. And after this, we might start considering another release...! -- / daniel.haxx.se ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/ _______________________________________________ libssh2-devel mailing list libssh2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/libssh2-devel
