On Sun, 8 Mar 2009, Peter Stuge wrote: >> But it is an even define and the comment next by the define even says it >> should remain even, so is it really necessary to do this extra precaution? > > Maybe not. But I would still like the loop to use cookie_len instead of the > define, and then the alloc is needed anyway..
Yeah, either that or we have a maximum auth cookie length that we deal with that can be pre-malloced (in the LIBSSH2_CHANNEL struct) or used on stack. I'm reluctant to add new very short-lived mallocs as I want to work on decreasing the amount of mallocs generally all over. -- / daniel.haxx.se ------------------------------------------------------------------------------ Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA -OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise -Strategies to boost innovation and cut costs with open source participation -Receive a $600 discount off the registration fee with the source code: SFAD http://p.sf.net/sfu/XcvMzF8H _______________________________________________ libssh2-devel mailing list libssh2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/libssh2-devel
