On Monday 20 January 2014 10:26:41 Aris Adamantiadis wrote:
> Hi Jon,
>
> Thanks for your patch. I was skeptic until I read your reference links,
> thanks for including them.
>
> Could you just tweak your patch to remove the NULL tests ?
> ssh_string_data is guaranteed to return non-NULL by construction. With
> this you can also remove the paderrout: label.
>
> Regards,
>
> Aris
>
> Le 20/01/14 04:08, Jon Simons a écrit :
> > + blob_padded_data = (char *) ssh_string_data(sig_blob_padded);
> > + if (blob_padded_data == NULL) {
> > + goto paderrout;
> > + }
> > +
> > + blob_orig = (char *) ssh_string_data(sig_blob);
> > + if (blob_orig == NULL) {
> > + goto paderrout;
> > + }
Thanks for your patch.
Instead of memset(), please use the BURN_BUFFER() macro. It ensures that the
compiler doesn't optimize away the memset().
Cheers,
-- andreas
--
Andreas Schneider GPG-ID: CC014E3D
www.cryptomilk.org [email protected]
