On Thursday, September 10, 2015 09:50:23 AM Dirkjan Bussink wrote: > Hi Andreas, > > > On 25 Aug 2015, at 00:09, Andreas Schneider <[email protected]> wrote: > > > > thank you very much for your contribution. Do not expect a review before > > next week. I will be not available the rest of the week. > > I was wondering if you had any feedback to share? I’m happy to fix / improve > or change things where needed :).
Hi Dirkjan, your changes look perfectly fine, however they need to wait. I'm currently rewriting our test environment so that testing is just calling 'make test' without setting up accounts, ssh keys etc. I've already migrated most of the tests. My work in progress branch is here: https://git.libssh.org/users/asn/libssh.git/log/?h=master-cwrap You need https://cwrap.org to run them. However not all tests will work for you because the wrappers require some changes. Some of them are just available in a hackish way, like getspnam() support in nss_wrapper to fake shadow file access. After this is working we need to run pkd daemon in a cwrap env for testing! -- andreas
