On Tuesday, 27 November 2018 17:56:23 CET Tilo Eckert wrote:
> Hello Jakub,

Hi Tilo,

> the solution looks fine to me except for the assignment
> sig->type_c = pubkey->type_c

The type_c is an internal shortcut to avoid conversions and allocations, 
should it should be kept a `const char *` only pointing to text data. It 
should not be allocated.

The patch is fine, it should should not call strdup().


        Andreas


-- 
Andreas Schneider                 a...@cryptomilk.org
GPG-ID:     8DFF53E18F2ABC8D8F3C92237EE0FC4DCC014E3D



Reply via email to