-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
Ralf Wildenhues wrote: | First off: My laptop was broke last week, then some of our department's | hardware was destroyed, so: no mail reading, thus no patch checks, no | 1.5.18 release.
Do you need someone else to make the release? Sorry to hear about your hardware troubles.
| Discussion: | ----------- | Immediate consequence for the libjava folks: Use of -objectlist is to be | preferred, with their (ancient!) libtool as well as with HEAD after the | changes below. I have another optimization idea for -objectlist which | will kill some of the 2.8s left, but it needs more work, and might not | be immediately necessary.
Use of -objectlist with libjava is required, I haven't built libjava in a little while, I thought they used it, if not they are undoubtedly exceeding the kernel limit on command line lenght on some systems.
| Changes: | -------- | | My patches break one assumption held in libtool so far: that --dry-run | will cause no file changes.
I understand your reasons for breaking this, but it freaks me out a little bit. Have you reported the quadratic behavior to the bash maintainers? We need to file bugs with them about this too. Note that some of your FIXMEs in the patches below are in my opinion not needed, if libtool got the argument list and -objectlist was not used then the kernel limit was not exceeded and $ECHO is fine.
| | OK to apply them all to HEAD?
I am loathe to say 'No', but I will ask that you not commit these to HEAD without explicit approval.
speedup-features2.diff OK speedup-fixme2.diff OK (even thought these comments may not always be warranted a reminder about command line length can't hurt)
The others scare me, I don't like the tempfiles. If no other maintainer approves in a few days I will look more closely.
Peter - -- Peter O'Gorman - http://www.pogma.com -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.0 (Darwin)
iQCVAwUBQoIXz7iDAg3OZTLPAQJLSAP/Ubd16UtZ+zgNH0v7lS023Cn5tTakcWSZ QWm/Brwm8rJBBBXUwirm3yMhLSli6XdS60Q2Ep9KO9desNWm/O4m+5kexv58CeG5 2MR6sl226bYs2idUwPd2S5ah5mG8GjSlzqVTRkWqgDdNiIneWXlUzCqIFy1NIBFE 96D4cCRwJxI= =lruL -----END PGP SIGNATURE-----
