Ralf Wildenhues wrote:
Hi Gary,
Hallo Ralf,
* Gary V. Vaughan wrote on Wed, Oct 05, 2005 at 02:48:36PM CEST:I think there is a bug in this commit: Ralf Wildenhues wrote:Index: tests/testsuite.at =================================================================== RCS file: /cvsroot/libtool/libtool/tests/testsuite.at,v retrieving revision 1.22 diff -u -r1.22 testsuite.at --- tests/testsuite.at 30 Sep 2005 16:00:23 -0000 1.22 +++ tests/testsuite.at 5 Oct 2005 08:57:25 -0000*snip*# LT_AT_LIBTOOLIZE([ARGS]) # ------------------------ m4_define([LT_AT_LIBTOOLIZE], -[_lt_pkgdatadir="$abs_top_srcdir" "$LIBTOOLIZE" $1Was this deliberate? Most of my tests now fail because libtoolize is looking in the (not yet) installed macro tree for files to copy...+[$LIBTOOLIZE $1 ])Yes, this was deliberate. It should've been compensated by this part: | Index: Makefile.am | =================================================================== | RCS file: /cvsroot/libtool/libtool/Makefile.am,v | retrieving revision 1.168 | diff -u -r1.168 Makefile.am | --- Makefile.am 30 Sep 2005 16:00:21 -0000 1.168 | +++ Makefile.am 5 Oct 2005 08:57:25 -0000 | @@ -492,6 +492,9 @@ | FC="$(FC)" FCFLAGS="$(FCFLAGS)" \ | GCJ="$(GCJ)" GCJFLAGS="$(GCJFLAGS)"| | +BUILDCHECK_ENVIRONMENT = _lt_pkgdatadir="$(abs_top_srcdir)"| +INSTALLCHECK_ENVIRONMENT = | + | check-recursive: $(srcdir)/$(TESTSUITE)| | # Use `$(srcdir)' for the benefit of non-GNU makes: this is | | @@ -520,12 +523,12 @@| # Hook the test suite into the check rule | check-local: tests/atconfig $(srcdir)/$(TESTSUITE) | $(CD_TESTDIR); \ | - $(TESTS_ENVIRONMENT) $(SHELL) $$abs_srcdir/$(TESTSUITE) $(TESTSUITE_FLAGS) | + $(TESTS_ENVIRONMENT) $(BUILDCHECK_ENVIRONMENT) $(SHELL) $$abs_srcdir/$(TESTSUITE) $(TESTSUITE_FLAGS)| | # Run the test suite on the *installed* tree.| installcheck-local: | $(CD_TESTDIR); \ | - $(TESTS_ENVIRONMENT) $(SHELL) $$abs_srcdir/$(TESTSUITE) $(TESTSUITE_FLAGS) AUTOTEST_PATH=$(exec_prefix)/bin | + $(TESTS_ENVIRONMENT) $(INSTALLCHECK_ENVIRONMENT) $(SHELL) $$abs_srcdir/$(TESTSUITE) $(TESTSUITE_FLAGS) | +AUTOTEST_PATH=$(exec_prefix)/bin| | # We need to remove any file droppings left behind by testsuite| clean-local: clean-local-legacy and indeed I can make tests fail if I change, for example, above setting of _lt_pkgdatadir to point to a non-existing directory, with both GNU make and `pmake' On which system does this fail? Which `make' implementation, automake and autoconf version?
On my darwin dev machine, GNU Make 3.80 as shipped by Apple with 10.4.2,
automake-1.9.6 and autoconf-2.59 installed by me to /usr/local with the
patches to support AC_CONFIG_LIBOBJ_DIR applied. Just to be sure, I ran
the following:
$ cvs -d :ext:[EMAIL PROTECTED]:/cvsroot/libtool co libtool
...
$ cd libtool
$ ./bootstrap
...
(order a pizza)
...
(make coffee)
...
(drink coffee)
...
(pizza arrives)
...
(eat some pizza)
...
(remaining pizza goes cold)
...
(go for a walk)
...
(make more coffee)
...
(reheat pizza)
...
(drink coffee)
...
(eat more pizza)
...
(take a nap)
...
(go to tae kwon do)
...
(have a shower)
...
(watch 4 episodes of Lost)
...
(and a rerun of Buffy)
...
(take a cold shower)
...
(read War & Peace)
...
(twice)
...
(have a good night's sleep)
...
(dream about rewriting HACKING to mention that ordering a pizza is not enough)
...
(write libtool-3.0 in perl)
...
(wake up in a cold sweat)
...
$ mkdir +build
$ cd +build
$ ../configure --prefix=`cd .. && pwd`/+inst
## ------------------------------------------------------------ ##
## Configuring libtool (Build: 1.2113 2005/10/05 09:42:39) 2.1a ##
## ------------------------------------------------------------ ##
...
$ make
...
$ make check-local TESTSUITE_FLAGS='-v -d 1'
abs_srcdir=`CDPATH="${ZSH_VERSION+.}:" && cd .. && pwd`; cd tests; \
MAKE="make" CC="gcc" CFLAGS="-g -O2" CPP="gcc -E" CPPFLAGS="" LD="/usr/bin/ld" LDFLAGS="" LIBS="" LN_S="ln -s" NM="/usr/bin/nm -p" RANLIB="ranlib" OBJEXT="o" EXEEXT="" SHELL="/bin/sh"
CONFIG_SHELL="/bin/sh" CXX="g++" CXXFLAGS="-g -O2" CXXCPP="g++ -E" F77="gfortran" FFLAGS="-g -O2" FC="gfortran" FCFLAGS="-g -O2" GCJ="gcj" GCJFLAGS="-g -O2" _lt_pkgdatadir="" /bin/sh $abs_srcdir/tests/testsuite -v -d 1
## ------------------------ ##
## libtool 2.1a test suite. ##
## ------------------------ ##
1. libtoolize.at:71: testing ...
libtoolize.at:86:
/Users/gary/devel/savannah/libtool/+build/tests/.././libtoolize --copy
--- /dev/null 2005-10-05 14:24:22.000000000 +0100
+++ /Users/gary/devel/savannah/libtool/+build/tests/testsuite.dir/at-stderr
2005-10-05 14:24:22.000000000 +0100
@@ -0,0 +1 @@
+libtoolize: $pkgltdldir not a directory:
`/Users/gary/devel/savannah/libtool/+inst/share/libtool'
--- expout 2005-10-05 14:24:22.000000000 +0100
+++ /Users/gary/devel/savannah/libtool/+build/tests/testsuite.dir/at-stdout
2005-10-05 14:24:22.000000000 +0100
@@ -1,8 +0,0 @@
-libtoolize: putting files in AC_CONFIG_AUX_DIR, `config'.
-libtoolize: copying file `config/ltmain.sh'
-libtoolize: putting macros in AC_CONFIG_MACRO_DIR, `m4'.
-libtoolize: copying file `m4/libtool.m4'
-libtoolize: copying file `m4/argz.m4'
-libtoolize: copying file `m4/ltoptions.m4'
-libtoolize: copying file `m4/ltsugar.m4'
-libtoolize: copying file `m4/ltversion.m4'
libtoolize.at:86: exit code was 1, expected 0
1. libtoolize.at:71: FAILED (libtoolize.at:86)
## ------------- ##
## Test results. ##
## ------------- ##
ERROR: 1 test was run,
1 failed unexpectedly.
## -------------------------- ##
## testsuite.log was created. ##
## -------------------------- ##
Please send `testsuite.log' and all information you think might help:
To: <[email protected]>
Subject: [libtool 2.1a] testsuite: 1 failed
make: *** [check-local] Error 1
:-(
Ahah! $(abs_top_srcdir) is not defined by autoconf-2.59 :->
Cheers,
Gary.
--
Gary V. Vaughan ())_. [EMAIL PROTECTED],gnu.org}
Research Scientist ( '/ http://tkd.kicks-ass.net
GNU Hacker / )= http://www.gnu.org/software/libtool
Technical Author `(_~)_ http://sources.redhat.com/autobook
signature.asc
Description: OpenPGP digital signature
