Hi Peter, * Peter O'Gorman wrote on Thu, May 18, 2006 at 01:14:11AM CEST: > On Wed, 2006-05-17 at 20:53 +0200, Ralf Wildenhues wrote: > > This patch fixes a long-standing compile time regression of HEAD over > > branch-1-5. > > > Any reasons against applying this now? > > I think this is okay.
Thanks! Applied. > A question though, in branch-1.5 we only unset modify LC_ALL and LANG, > don't we? Why do we need to change the others here? Well, that is a bug in branch-1-5. I'll fix it. If LC_ALL and LANG are both unset, but LC_COLLATE is set, then that setting is used for collating. We could limit ourselves to LANG and LC_ALL, but only if we *set* the latter. Because of the warning that some systems may not grok LC_ALL=C (I'm pretty sure those systems are not in wide use any more, if at all), I'd rather not do that unconditionally. Cheers, Ralf
