Ralf Wildenhues wrote: > Hello Gary, Hallo Ralf!
> This has been so long ago it's a shame: > http://lists.gnu.org/archive/html/libtool-patches/2005-12/msg00075.html So long that I'd completely forgotten about it!! > * Gary V. Vaughan wrote on Wed, Dec 14, 2005 at 01:39:55PM CET: >> Ralf Wildenhues wrote: >>> This patch is the last of the queue, and the most intertwined. Maybe I >>> should make the effort to rip it apart -- please say so. >> Yes please. Unless it is a disproportionate amount of effort, in which >> case I'd rather spend that effort on rolling 1.9h. > > The fact that I haven't found the time to rip it apart in 6 months is > enough reason for me to just apply it in one go. Agreed. >>> Note that in the symlink-case, this file *must* retain its old time >>> stamp, hence `cp -p'. Maybe we'd need `tar' instead here? >> I'm not sure `cp -p' is portable enough. We've used `tar' previously >> because of this (among other things). > > I've changed the patch to use tar. Although I really really doubt there > to be any real advantage here of tar over cp -p. If there were such an > issue, it should definitly be mentioned in the Autoconf portability > section. I don't remember what the issues were that we encountered :-( But, we did have good reason for moving from cp -p to tar back in the day. I don't mind trying to revert to cp -p after the release if the archives don't hold a good reason not to. >>> (Luckily the subsecond problem is not *so* much of an issue here: >>> `cd libltdl && aclocal' still takes a second on a fast machine -- >>> maybe we should put a `sleep 1' into the manual rule even?) >> Yes, I think the sleep is a good idea for future proof against ultra >> fast machines that decide not to upgrade to libtool-3.0 in 2025 ;-) > > Let's not do that yet. Maybe after the stuff has stabilized. Good. I was just kidding!! :-D >>> As a final bit, we default $tst_dist to `dist' now -- should work. :) >> I'd rather not have casual installers be even more likely to get bored >> and abort the testsuite run. What do you think of my LT_TEST_EXHAUSTIVE >> idea? > > The dist part isn't so much more expensive at all; you may have been > thinking of distcheck, which would really be expensive. But dist > uncovers the bugs fixed in this patch, and I definitely want to see > those. ACK. >> As a general rule, the ChangeLog entry itself should be sufficient >> documentation for why the changeset is necessary. If you find yourself >> wanting to add more description to the libtool-patches post, rather >> add it to the ChangeLog entry instead for future readers. > > I've added some of the description to the ChangeLog entry now. Excellent. Thanks. > I've applied the patch as shown below. Thanks for remembering! Once I've got my dev environment set up again, I have a couple of patches in quilt that need resynching with HEAD, and that need consideration before 2.0. > Fix several libtoolize-related bugs: > - Do not symlink aclocal.m4, to work around a bug in aclocal > overwriting the linked-to file instead of removing the symlink. > - Have `libtoolize --copy' cause current time stamps, so that > dependents will be rebuilt; for this, install files in order. > - Fix list of distribution files for (non)recursive libltdl. > - Fix some failure cases. > > * libtoolize.m4sh (func_copy_cb): > If `$opt_link', still copy `aclocal.m4', so a subsequent > `aclocal' will not overwrite the symlink target. > In `--copy' mode, do `cp -p' and `touch' for each file, so > timestamps are updated but permissions preserved. > (main): Reorder installing of files to match logical order > and timestamp requirements. > (func_fixup_Makefile_inc): Renamed to > (func_fixup_Makefile): this. Add sed scriptlet to remove > non-existent files from EXTRA_DIST, for either nonrecursive > or recursive mode. > (main): call it to mangle also in recursive mode. > * tests/libtoolize.at (expout): Adjusted. > * tests/testsuite.at (tst_dist): Default to `dist'. All good! Cheers, Gary. -- Gary V. Vaughan ())_. [EMAIL PROTECTED],gnu.org} Research Scientist ( '/ http://blog.azazil.net GNU Hacker / )= http://trac.azazil.net/projects/libtool Technical Author `(_~)_ http://sources.redhat.com/autobook
signature.asc
Description: OpenPGP digital signature
