Hi Peter,

* Peter O'Gorman wrote on Tue, Sep 12, 2006 at 05:34:50PM CEST:
> On Sep 12, 2006, at 7:41 AM, Ralf Wildenhues wrote:
> 
> >This patch provides a couple of tests for staged installations.

> >OK to install?  There will be more tests to this end, these should
> >be the least problematic.
> 
> New tests almost count as "obvious", don't you think? :-)

Well.  The part I posted should pretty much be obvious, at least I hope
so.  I separated it from the next because that will likely be less
unanimous.  And of course, I posted it in the hope that any silly
glitches of mine could be spotted.  :-)

Other than that: new tests that I (have to) maintain and either I don't
understand, or seem maintenance-intensive, or otherwise problematic,
certainly don't fall under the obvious rule, if you ask me.  FWIW, I
have tests lying on my disk for quite a while that I've never submitted,
because they would be problematic (this one started some months ago).

> This is okay, is not portable with objdump, but that can be dealt  
> with later, either by limiting the systems the test is run on, or  
> making the test more portable.

Certainly.

Thanks for the review!  Installed.

Cheers,
Ralf


Reply via email to