On Tue, 10 Apr 2007, Gary V. Vaughan wrote:

 int errors = 0;
 lt_dlhandle handle;
 lt_dladvise advise = lt_dladvise_init ();

 if (advise == 0)
   return 1;

Not ideal. By comparing with zero there is an implicit assumption regarding the lt_dladvise type. It is usually better to avoid any user knowledge of the type:

  lt_dladvise advise;
  if (!lt_dladvise_init(&advise))
     return 1;

In this way, lt_dladvise can be a pointer, an integer, or a structure.

Bob
======================================
Bob Friesenhahn
[EMAIL PROTECTED], http://www.simplesystems.org/users/bfriesen/
GraphicsMagick Maintainer,    http://www.GraphicsMagick.org/



Reply via email to