Hi Charles, Bruno, * Charles Wilson wrote on Thu, Apr 26, 2007 at 07:34:56AM CEST: > > Attached. Re-ran *all* of the tests described here: > http://lists.gnu.org/archive/html/libtool-patches/2007-04/msg00073.html > with identical results.
Thank you for patching and testing, and thanks to Bruno for the fine review. > I did not bump the argz.m4 serial again (I'm not sure what the rules are: > bump on EVERY change, or only on "big" changes?). So, Ralf, please do that > manually if it is necessary. It can't hurt, so I did that, and applied (libtool and gnulib). > + if test "$lt_os_major" -gt 1 \ > + || { test "$lt_os_major" -eq 1 \ > + && { test "$lt_os_minor" -gt 5 \ > + || { test "$lt_os_minor" -eq 5 \ > + && test "$lt_os_micro" -gt 24; }; }; }; then Bruno asked for this GCS compliant formatting. I have some (very minor) issue with it: it looks uglier in shell, due to the necessary backslashes. Also, the GCS specify this for C code only, to be strict. But I'm not all that strong about it, so I left it in your patch. Cheers, Ralf