Let's see if this message makes it to the list... * Charles Wilson wrote on Thu, Jul 12, 2007 at 09:48:30AM CEST: > Ralf Wildenhues wrote: >> The libtool.m4 part of this patch also needs an instance of the function >> in case the shell does not support XSI extensions. > > Oh, I missed that. Didn't realize we had two implementations of everything.
That's the point of having them in libtool.m4 in the first place: to provide a fast implementation if the shell is capable. >> Inside that >> function, you could make use of the other ones (func_dirname and >> func_basename) if it helps. > > No, if I did that then using the combo function would actually be *worse*, > from an execution-time standpoint, than calling the separate functions > explicitly. Just like the XSI versions, I think cut-n-paste with an > explicit comment about "keep this in sync" is the way to go, here. ACK. >> Testing on Solaris with /bin/sh should expose this. Your patch seems to work OK there. Thanks, please apply. Cheers, Ralf > 2007-07-12 Charles Wilson <...> > > * libltdl/m4/libtool.m4 (func_dirname_and_basename) <XSI>: > New function > (func_dirname_and_basename) <!XSI>: New function. > * libltdl/config/ltmain.m4sh (func_ltwrapper_scriptname): > Call it. Also, take advantage of missed optimization using > func_dirname's additional arguments. > (func_mode_compile): Call it. > (func_mode_install): Call it. > (func_mode_link): Call it.
