Hi Peter,

* Peter O'Gorman wrote on Tue, Mar 04, 2008 at 07:14:51AM CET:
> Ralf Wildenhues wrote:
> > 
> > So I'd appreciate a review of this, and also test results on systems
> > with loaders other than preopen and dlopen.  (I haven't even tested
> > successful compilation on those other systems.)
> 
> I did not manage to try the shl_load loader, only tested dyld. This
> patch causes no regressions on Mac OS X 10.2. If that is also true for
> the loaders you get around to trying, this is ok.

For the preopen, dlopen, shl_load loaders, I confirmed that the
testsuite addition exposes the bug, and the loader changes fixes the
testsuite failure.  For loadlibrary, I only cross-compiled from
GNU/Linux to ensure absense of typos.

I visually inspected the BeOS and dld changes again for typos, and then
applied the patch, after adding a NEWS entry.

> Thank you. Once again you sent a patch for a bug before I even got
> around to reading the list.

My pleasure.  :-)  Kudos to Andreas for reporting the bug.

Cheers,
Ralf


Reply via email to